New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gesture disposed check to FrameRenderer #829

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
6 participants
@hartez
Member

hartez commented Mar 21, 2017

Description of Change

This applies the same fix from PR 706 to FrameRenderer.

Bugs Fixed

if (_gestureDetector.IsValueCreated && _gestureDetector.Value.Handle == IntPtr.Zero)
{
// This gesture detector has already been disposed, probably because it's on a cell which is going away

This comment has been minimized.

@mattrichnz

mattrichnz Mar 21, 2017

Contributor

This comment needs to be updated - "it's on a cell which is going away", perhaps change to "it's on a view which is going away".

@mattrichnz

mattrichnz Mar 21, 2017

Contributor

This comment needs to be updated - "it's on a cell which is going away", perhaps change to "it's on a view which is going away".

This comment has been minimized.

@hartez

hartez Mar 21, 2017

Member

The situation being addressed is a gesture detector which has been disposed on the Java side because the list view cell which contains it has been collected - see the description from the original PR.

@hartez

hartez Mar 21, 2017

Member

The situation being addressed is a gesture detector which has been disposed on the Java side because the list view cell which contains it has been collected - see the description from the original PR.

This comment has been minimized.

@mattrichnz

mattrichnz Mar 22, 2017

Contributor

OK I see, however I have also seen the gesture detector being disposed when a List View is not being used hence my comment. Particularly noticeable when using Tarjan.

@mattrichnz

mattrichnz Mar 22, 2017

Contributor

OK I see, however I have also seen the gesture detector being disposed when a List View is not being used hence my comment. Particularly noticeable when using Tarjan.

@rmarinho rmarinho merged commit 7538350 into master Mar 22, 2017

3 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3749, ignored: 10
Details

@hartez hartez deleted the fix-bugzilla45330-part2 branch May 16, 2017

@samhouts samhouts added D15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.5.0 milestone May 5, 2018

@samhouts samhouts modified the milestones: 2.5.0, 2.3.4 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment