New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bz53803 Android app crashes during initialization due to invalid cast… #835

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
4 participants
@BradChase2011
Contributor

BradChase2011 commented Mar 22, 2017

… of toolbar TextView.

Description of Change

Changed the lookup for the TextView in the Toolbar instead of assuming the first element.

Bugs Fixed

API Changes

None.

Behavioral Changes

FormsApplicationActivity should load without an InvalidCastException.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
bchaseicantfindanotherusername
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Mar 22, 2017

@BradChase2011,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Mar 22, 2017

@BradChase2011,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@BradChase2011

This comment has been minimized.

Show comment
Hide comment
@BradChase2011

BradChase2011 Mar 22, 2017

Contributor

Bugzilla references:
https://bugzilla.xamarin.com/show_bug.cgi?id=53803

Older PR references:
#631

Contributor

BradChase2011 commented Mar 22, 2017

Bugzilla references:
https://bugzilla.xamarin.com/show_bug.cgi?id=53803

Older PR references:
#631

@rmarinho rmarinho merged commit 349969f into xamarin:master Mar 24, 2017

5 of 6 checks passed

iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests f…
Details
Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3751, ignored: 10
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts added this to Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts removed this from Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment