[Android] ScrollView can now consume Effects #836

Merged
merged 2 commits into from Mar 23, 2017

Conversation

Projects
None yet
5 participants
@samhouts
Member

samhouts commented Mar 22, 2017

Description of Change

Made Android ScrollView an IEffectControlProvider'.

Bugs Fixed

Needs to be backported to 2.3.4

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

samhouts added some commits Mar 22, 2017

@hartez

hartez approved these changes Mar 23, 2017

@hartez hartez merged commit 79ecf97 into master Mar 23, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3754, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@samhouts samhouts deleted the fix-bugzilla45874 branch Apr 19, 2017

@UdaraAlwis

This comment has been minimized.

Show comment
Hide comment
@UdaraAlwis

UdaraAlwis Sep 7, 2017

@samhouts Awesome work! any idea when they will release this merge? Currently I'm unable to attach Effects to ScrollView on Android runtime :(

EDIT:
Oh never mind, just found out its still in pre-release :(
https://bugzilla.xamarin.com/show_bug.cgi?id=45874
too bad even such simple fixes like this takes long time to be released to Stable. :( Sigh!

UdaraAlwis commented on c3a90a4 Sep 7, 2017

@samhouts Awesome work! any idea when they will release this merge? Currently I'm unable to attach Effects to ScrollView on Android runtime :(

EDIT:
Oh never mind, just found out its still in pre-release :(
https://bugzilla.xamarin.com/show_bug.cgi?id=45874
too bad even such simple fixes like this takes long time to be released to Stable. :( Sigh!

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment