New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Don't skip row height estimation for grouped lists #838

Merged
merged 3 commits into from Mar 24, 2017

Conversation

Projects
None yet
4 participants
@samhouts
Member

samhouts commented Mar 24, 2017

Description of Change

Reverting to calculating the estimated row height for grouped lists in the likely event that the group header has a known height. Related to #454.

Bugs Fixed

Needs to be backported to 2.3.4

API Changes

None

Behavioral Changes

May reintroduce the scrolling issues for grouped lists that were fixed by #454.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

samhouts added some commits Mar 24, 2017

@samhouts samhouts requested review from hartez and rmarinho Mar 24, 2017

@rmarinho rmarinho merged commit eea0bdc into master Mar 24, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3754, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

rmarinho added a commit that referenced this pull request Mar 24, 2017

[iOS] Don't skip row height estimation for grouped lists (#838)
* Nest bugzilla 51536 classes for less pollution

* Add repro for 53834

* [iOS] Don't skip row height estimation for grouped lists

rmarinho added a commit that referenced this pull request Mar 24, 2017

[iOS] Don't skip row height estimation for grouped lists (#838)
* Nest bugzilla 51536 classes for less pollution

* Add repro for 53834

* [iOS] Don't skip row height estimation for grouped lists

@samhouts samhouts deleted the fix-bugzilla53834 branch Apr 19, 2017

@samhouts samhouts added D15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.4 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment