New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Still look for the normal drawable on resources #839

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
5 participants
@rmarinho
Member

rmarinho commented Mar 24, 2017

Description of Change

Fix lookup of resources provided via drawable xml

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=53909

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@kingces95 kingces95 self-requested a review Mar 24, 2017

@kingces95

Tho seems a shame to have to duplicate the ?? logic everywhere. Could it be an extension on the context?

@rmarinho rmarinho merged commit 63af840 into master Mar 24, 2017

2 of 3 checks passed

Android-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3754, ignored: 10
Details

rmarinho added a commit that referenced this pull request Mar 24, 2017

[Android] Still look for the normal drawable on resources (#839)
* [Android] Still look for the normal drawable on resources

* [Android]Fix code style

@rmarinho rmarinho deleted the fix-bugzilla53909 branch Apr 11, 2017

@samhouts samhouts added D15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment