[Xaml] Set the TargetProperty on ServiceProvider #847

merged 1 commit into from Apr 7, 2017


None yet
3 participants

StephaneDelcroix commented Mar 30, 2017

Description of Change

[Xaml] Set the TargetProperty on ServiceProvider

The TargetProperty was set in XamlC scenarios. Set it on uncompiled Xaml too.
This is an alternate version of #814.

Bugs Fixed

API Changes


Behavioral Changes


PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix merged commit 5ea000a into master Apr 7, 2017

1 of 2 checks passed

OSX-Debug-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3764, ignored: 10

@samhouts samhouts deleted the targetProperty branch Apr 7, 2017

vvs0205 added a commit to MugenMvvmToolkit/MugenMvvmToolkit that referenced this pull request May 8, 2017

fixed #19
should be fixed in 2.3.5-pre1

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment