New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Section indexes when FastScrolled is enabled #850

Merged
merged 4 commits into from Apr 6, 2017

Conversation

Projects
None yet
5 participants
@Clancey
Member

Clancey commented Mar 31, 2017

Description of Change

This adds the native Section indexes while fast scrolling on Android

API Changes

All changes were internal api

Added:

  • GroupedListViewAdapter

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho

Small code style fixes

Show outdated Hide outdated Xamarin.Forms.Platform.Android/Renderers/ListViewAdapter.cs
public Java.Lang.Object [] GetSections ()
{
Setup ();

This comment has been minimized.

@rmarinho

rmarinho Apr 6, 2017

Member

Need to fix the code style, we don't use spaces here

@rmarinho

rmarinho Apr 6, 2017

Member

Need to fix the code style, we don't use spaces here

Show outdated Hide outdated Xamarin.Forms.Platform.Android/Renderers/ListViewAdapter.cs
{
_listCount = -1;
}
}
internal class GroupedListViewAdapter : ListViewAdapter, ISectionIndexer

This comment has been minimized.

@rmarinho

rmarinho Apr 6, 2017

Member

Can we move this to other class?!

@rmarinho

rmarinho Apr 6, 2017

Member

Can we move this to other class?!

@@ -335,8 +335,9 @@ void UpdateIsSwipeToRefreshEnabled()
void UpdateFastScrollEnabled()
{
if (Control != null)
Control.FastScrollEnabled = Element.OnThisPlatform().IsFastScrollEnabled();
if (Control != null) {

This comment has been minimized.

@rmarinho

rmarinho Apr 6, 2017

Member

no need for change here

@rmarinho

rmarinho Apr 6, 2017

Member

no need for change here

@rmarinho rmarinho requested a review from jassmith Apr 6, 2017

Clancey added some commits Apr 6, 2017

Merge branch 'master' into android-section-indexes
# Conflicts:
#	Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
@jassmith

+1 Setup should probably be renamed ValidateSectionData or something similar to match the naming of the locking variable

@rmarinho rmarinho merged commit 3d9d1d3 into master Apr 6, 2017

@rmarinho rmarinho deleted the android-section-indexes branch Apr 6, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment