New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling API not available in all versions #877

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
5 participants
@kingces95
Member

kingces95 commented Apr 19, 2017

Description of Change

Calling an API not available in all versions of Android.

Bugs Fixed

https://forums.xamarin.com/discussion/comment/267383/#Comment_267383
https://bugzilla.xamarin.com/show_bug.cgi?id=55230

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@StephaneDelcroix

StephaneDelcroix approved these changes Apr 19, 2017 edited

if it's a regression and needs to be backported, please add a note @kingces95 @kingces95 @kingces95

@kingces95

This comment has been minimized.

Show comment
Hide comment
@kingces95

kingces95 Apr 19, 2017

Member

@rmarinho, you noted in the channel that because this is a fast renderer that it cannot be a regression. From that I assume it does not need to be backported.

Member

kingces95 commented Apr 19, 2017

@rmarinho, you noted in the channel that because this is a fast renderer that it cannot be a regression. From that I assume it does not need to be backported.

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Apr 19, 2017

Member

Sorry may i expressed myself wrong, it has to be backported to 2.3.5 , but is not a regression because it's a new feature, it's just a bugfix on a new feature that needs to be cherrypicked to 2.3.5 branch for 2.3.5-pre2

Member

rmarinho commented Apr 19, 2017

Sorry may i expressed myself wrong, it has to be backported to 2.3.5 , but is not a regression because it's a new feature, it's just a bugfix on a new feature that needs to be cherrypicked to 2.3.5 branch for 2.3.5-pre2

@rmarinho rmarinho merged commit b0b43c6 into master Apr 19, 2017

3 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3770, ignored: 10
Details
Windows-Release Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Release Unit Tests : Tests passed: 3770, ignored: 10
Details
@kingces95

This comment has been minimized.

Show comment
Hide comment
@kingces95

kingces95 Apr 19, 2017

Member

Cherry-picked to 2.3.5; 2dba305

Member

kingces95 commented Apr 19, 2017

Cherry-picked to 2.3.5; 2dba305

@rmarinho rmarinho deleted the formsbug branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment