New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Prevent NRE in ListView OnItemSelected #883

Merged
merged 3 commits into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
@samhouts
Member

samhouts commented Apr 25, 2017

Description of Change

Changes made in #520 will allow the code in OnItemSelected to execute in more situations, including when the ListView has already been disposed. In this situation, we will get a NullReferenceException. Adding a null check to prevent this. Exception was not observed on Android, but I added a check there nonetheless to be safe.

Bugs Fixed

  • Not reported

----Please backport to 2.3.5----

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

samhouts added some commits Apr 20, 2017

[Android] Prevent NRE in ListView
Not observed, but adding defensive check just in case

@jassmith jassmith merged commit 17c7d8e into master Apr 25, 2017

1 check was pending

Windows-Debug-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug
Details

@samhouts samhouts deleted the listviewnre branch Apr 25, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts added this to Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts removed this from Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment