New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugzilla55607 - [iOS] Opening a ListView Cell's context action will disable context actions for all other ListViews #885

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
6 participants
@bruzkovsky
Contributor

bruzkovsky commented Apr 26, 2017

Description of Change

Added check for instance of UITableView, so that only one ContextAction can be open per ListView.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=55588
https://bugzilla.xamarin.com/show_bug.cgi?id=55607 (duplicate)

API Changes

None.

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Apr 26, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Apr 26, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@kingces95 kingces95 self-requested a review Apr 26, 2017

@kingces95

Fixes issue.

@kingces95 kingces95 merged commit 6ee219c into xamarin:master Apr 27, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3778, ignored: 10
Details
Windows-Release Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Release Unit Tests : Tests passed: 3778, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details

@bruzkovsky bruzkovsky deleted the bruzkovsky:fix-bugzilla55607-2 branch May 2, 2017

rmarinho added a commit that referenced this pull request Jun 22, 2017

@Ruddy2007

This comment has been minimized.

Show comment
Hide comment
@Ruddy2007

Ruddy2007 Jul 14, 2017

@bruzkovsky I have ran into a problem with this commit. You can get a null exception on this line. Im just going to guess that in (ContextScrollViewDelegate)scrollViewBeingScrolled.Delegate - scrollViewBeingScrolled can be null?

Just messing around by having two list views on two different pages, swiping to delete and then changing to the other listview causes this:
at Xamarin.Forms.Platform.iOS.ContextScrollViewDelegate.ShouldIgnoreScrolling (UIKit.UIScrollView scrollView) [0x00009] in C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Platform.iOS\ContextScrollViewDelegate.cs:206 at Xamarin.Forms.Platform.iOS.ContextScrollViewDelegate.DraggingStarted (UIKit.UIScrollView scrollView) [0x00000] in C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Platform.iOS\ContextScrollViewDelegate.cs:75 at (wrapper managed-to-native) UIKit.UIApplication:UIApplicationMain (int,string[],intptr,intptr) at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Users/builder/data/lanes/4691/d2270eec/source/xamarin-macios/src/UIKit/UIApplication.cs:79 at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x00038] in /Users/builder/data/lanes/4691/d2270eec/source/xamarin-macios/src/UIKit/UIApplication.cs:63

The simple fix would be to check for nulls....

@kingces95 @jassmith

Ruddy2007 commented Jul 14, 2017

@bruzkovsky I have ran into a problem with this commit. You can get a null exception on this line. Im just going to guess that in (ContextScrollViewDelegate)scrollViewBeingScrolled.Delegate - scrollViewBeingScrolled can be null?

Just messing around by having two list views on two different pages, swiping to delete and then changing to the other listview causes this:
at Xamarin.Forms.Platform.iOS.ContextScrollViewDelegate.ShouldIgnoreScrolling (UIKit.UIScrollView scrollView) [0x00009] in C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Platform.iOS\ContextScrollViewDelegate.cs:206 at Xamarin.Forms.Platform.iOS.ContextScrollViewDelegate.DraggingStarted (UIKit.UIScrollView scrollView) [0x00000] in C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Platform.iOS\ContextScrollViewDelegate.cs:75 at (wrapper managed-to-native) UIKit.UIApplication:UIApplicationMain (int,string[],intptr,intptr) at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Users/builder/data/lanes/4691/d2270eec/source/xamarin-macios/src/UIKit/UIApplication.cs:79 at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x00038] in /Users/builder/data/lanes/4691/d2270eec/source/xamarin-macios/src/UIKit/UIApplication.cs:63

The simple fix would be to check for nulls....

@kingces95 @jassmith

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request Jul 28, 2017

Merge branch '2.3.5' into ios-fastrenderers
* 2.3.5:
  [UWP] Fixes for usage of XF with .net native toolchain (#1024)
  [UWP] Make sure to update HitTestVisible when IsEnable changes (#1015)
  [Android] Dispose check before setting properties on Button (#1013)
  Add missing member variable to FormsApplicationActivity
  Fix NRE when background color of button set in FormsApplicationActivity (#1010)
  Fix border on android buttons  (#941)
  [iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (#994)
  Set the Id field for Android Views created by Forms #1004
  Fix build
  Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (#961)
  [Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (#915)
  Remove debug outputs (#1008)
  Add check for instance of UITableView (#885)
  [XamlC] fix release builds of Xaml Unit Tests
  Dispose check on ButtonRenderer (#975)
  [previewer] make sure we do not crash even if the previewer doesn't s… (#946)
  [XamlC] fix build
  Remove VisualElement finalizer (#918)
  [XamlC] process symbols if DebugType is set (#925)

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment