Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android|iOS] SwipeView in CollectionView selection #8856

Open
wants to merge 3 commits into
base: 4.5.0
from
Open

Conversation

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Dec 11, 2019

Description of Change

Using SwipeView with CollectionView, we apply changes in this PR to allow the interaction with the CollectionView (for example, SelectionChanged event) when are not doing swipe.

issue8774-ios

NOTE: Tests are still being done in the fix for Android. For that reason this branch has the "DO-NOT-MERGE!!!" tag.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Core Gallery and navigate to the issue 8774. Tap any item and verify that the SelectionChanged event of the CollectionView is executed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
@jsuarezruiz jsuarezruiz changed the title Fixed iOS Touch errors [Android|iOS] SwipeView in CollectionView selection Dec 11, 2019
@samhouts samhouts added the t/bug 🐛 label Dec 13, 2019
@samhouts samhouts added this to In Progress in vCurrent (4.4.0) Dec 13, 2019
@samhouts samhouts added the swipeview label Dec 20, 2019
@samhouts samhouts added this to In Review in CollectionView Jan 3, 2020
@samhouts samhouts removed the swipeview label Jan 8, 2020
@samhouts samhouts changed the base branch from 4.4.0 to 4.5.0 Jan 9, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.4.0) Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CollectionView
  
In Review
2 participants
You can’t perform that action at this time.