New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add disposed check on FastRenderers.LabelRenderer #886

Merged
merged 2 commits into from Apr 28, 2017

Conversation

Projects
None yet
4 participants
@bentmar
Contributor

bentmar commented Apr 27, 2017

Description of Change

Check if the Label is disposed on GetDesiredSize() on FastRenderer.LabelRenderer

Bugs Fixed

Doesnt crash if GetDesiredSize is called when Label is disposed

API Changes

none

Behavioral Changes

none

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
add disposed check on FastLabelRenderer
Description of Change

Check is the Label is dispodes on GetDesiredSize() on fast LabelRenderer

Bugs Fixed

System.ObjectDisposedException: Cannot access a disposed object.

API Changes

None

Behavioral Changes

None
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Apr 27, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Apr 27, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@bentmar bentmar changed the title from add disposed check on FastLabelRenderer to add disposed check on FastRenderers.LabelRenderer Apr 27, 2017

@bentmar bentmar changed the title from add disposed check on FastRenderers.LabelRenderer to [Android] Add disposed check on FastRenderers.LabelRenderer Apr 27, 2017

@rmarinho rmarinho merged commit e7c3cf3 into xamarin:master Apr 28, 2017

StephaneDelcroix added a commit that referenced this pull request May 3, 2017

[Android] Add disposed check on FastRenderers.LabelRenderer (#886)
* add disposed check on FastLabelRenderer 

Description of Change

Check is the Label is dispodes on GetDesiredSize() on fast LabelRenderer

Bugs Fixed

System.ObjectDisposedException: Cannot access a disposed object.

API Changes

None

Behavioral Changes

None

* Update LabelRenderer.cs

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request May 12, 2017

Merge branch '2.3.5' into ios-fastrenderers
* 2.3.5:
  [C] fix BP declaring Types for A11y (#913)
  [All] Rename Accessibility -> AutomationProperties (#912)
  Fix build
  [Core] Accessibility works with XamlC (#911)
  Fix bugzilla55542 (#898)
  [Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)
  Give layouts a chance to handle touch events after passing though immediate children (#902)
  Add disposed check on FastRenderer.VisualElemen... (#888)
  [Android] Add disposed check on FastRenderers.LabelRenderer (#886)
  add disposed check on FastRenderers.FrameRenderer (#887)
  [iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
  [Xaml] move ValueConverterProvider to Core (#890)

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment