Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corner clipping on ImageButton and Button (FR) (#7723) #8868

Merged
merged 1 commit into from Dec 17, 2019

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Dec 12, 2019

Description of Change

Cherry pick of corner clipping fixes

Testing Procedure

  • Make sure included ui test operates how you'd expect it to

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

* Clip Button/ImageButton to corner radius

* - add ui test

* - fix warnings

# Conflicts:
#	Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
@samhouts samhouts added this to In Review in v4.4.0 Dec 13, 2019
@samhouts samhouts merged commit 79d381d into 4.4.0 Dec 17, 2019
v4.4.0 automation moved this from In Review to Done Dec 17, 2019
@samhouts samhouts deleted the fix_corner_clipping_cherry_pick branch December 17, 2019 00:03
@samhouts samhouts added this to the 4.4.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.4.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants