New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 #899

Merged
merged 2 commits into from May 4, 2017

Conversation

Projects
None yet
5 participants
@pineapple216
Contributor

pineapple216 commented May 3, 2017

[Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602

Description of Change

Bugs

Bugs Fixed

[Android] Exception when setting the backgroundcolor of a frame
https://bugzilla.xamarin.com/show_bug.cgi?id=55559

NullPointerException when applying style
https://bugzilla.xamarin.com/show_bug.cgi?id=45602

API Changes

None.

Added:
a null check on the _bitmap object before creating a canvas with it.

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description): No, not necessary.
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas May 3, 2017

@pineapple216,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented May 3, 2017

@pineapple216,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas dnfclas added the cla-signed label May 3, 2017

Koen Hendriks

@rmarinho rmarinho merged commit 930c067 into xamarin:2.3.5 May 4, 2017

4 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3780, ignored: 10
Details
Windows-Release Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Release Unit Tests : Tests passed: 3780, ignored: 10
Details

rmarinho pushed a commit that referenced this pull request May 4, 2017

[Android] Add null check before creating and drawing canvas bugzilla …
…55559 & 45602 (#899)

* [Android] Add null check before creating and drawing canvas bugzilla 55559 & bugzilla 45602.

* [Android] REFACTOR Add null check before creating and drawing canvas bugzilla 55559 & 45602 #899

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request May 12, 2017

Merge branch '2.3.5' into ios-fastrenderers
* 2.3.5:
  [C] fix BP declaring Types for A11y (#913)
  [All] Rename Accessibility -> AutomationProperties (#912)
  Fix build
  [Core] Accessibility works with XamlC (#911)
  Fix bugzilla55542 (#898)
  [Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)
  Give layouts a chance to handle touch events after passing though immediate children (#902)
  Add disposed check on FastRenderer.VisualElemen... (#888)
  [Android] Add disposed check on FastRenderers.LabelRenderer (#886)
  add disposed check on FastRenderers.FrameRenderer (#887)
  [iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
  [Xaml] move ValueConverterProvider to Core (#890)

@samhouts samhouts added D-15.4 and removed cla-signed labels Oct 10, 2017

@samhouts samhouts modified the milestones: 2.3.0, 2.3.5 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment