New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Rename Accessibility -> AutomationProperties #912

Merged
merged 4 commits into from May 10, 2017

Conversation

Projects
None yet
5 participants
@samhouts
Member

samhouts commented May 9, 2017

Description of Change

Renamed Accessibility to AutomationProperties. ~~Based from #911. ~~

#889 and #904 will need to be rebased if this is merged first.

UPDATE: idem for #913, #914

Bugs Fixed

None

API Changes

Same properties exist from #713, but the namespace is now AutomationProperties.

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -1,19 +1,19 @@

namespace Xamarin.Forms
{
public class Accessibility
public class AutomationProperties

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix May 10, 2017

Member

when was this released first ? isn't this a breaking change ?

@StephaneDelcroix

StephaneDelcroix May 10, 2017

Member

when was this released first ? isn't this a breaking change ?

This comment has been minimized.

@DanRigby

DanRigby May 10, 2017

Member

@StephaneDelcroix 2.3.5-pre1 is when this class first appeared in a NuGet release.

@DanRigby

DanRigby May 10, 2017

Member

@StephaneDelcroix 2.3.5-pre1 is when this class first appeared in a NuGet release.

@StephaneDelcroix

if this isn't a breaking change (was the old class ever released ?), then 👍

samhouts added some commits May 9, 2017

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix May 10, 2017

Member

Rebased this branch. In case I made a mess, you can restore the old HEAD with

git reset --hard a117-rename cc8320c2c55de350050115142844f0ee18fac583
git push -f
Member

StephaneDelcroix commented May 10, 2017

Rebased this branch. In case I made a mess, you can restore the old HEAD with

git reset --hard a117-rename cc8320c2c55de350050115142844f0ee18fac583
git push -f
Show outdated Hide outdated Xamarin.Forms.Core/Xamarin.Forms.Core.csproj
@@ -477,7 +477,5 @@
</PropertyGroup>
<ItemGroup />
<ItemGroup />
<ItemGroup>
<Folder Include="Xaml\" />

This comment has been minimized.

@rmarinho

rmarinho May 10, 2017

Member

Sorry is this not needed ?

@rmarinho

rmarinho May 10, 2017

Member

Sorry is this not needed ?

@rmarinho rmarinho merged commit 4e83b8e into master May 10, 2017

1 of 2 checks passed

Windows-Release Started TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Release Unit Tests
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3791, ignored: 10
Details

rmarinho added a commit that referenced this pull request May 10, 2017

[All] Rename Accessibility -> AutomationProperties (#912)
* [All] Renamed Accessibility -> AutomationProperties

* Update docs

* Restore doc summaries

* Revert unintended csproj changes

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request May 12, 2017

Merge branch '2.3.5' into ios-fastrenderers
* 2.3.5:
  [C] fix BP declaring Types for A11y (#913)
  [All] Rename Accessibility -> AutomationProperties (#912)
  Fix build
  [Core] Accessibility works with XamlC (#911)
  Fix bugzilla55542 (#898)
  [Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)
  Give layouts a chance to handle touch events after passing though immediate children (#902)
  Add disposed check on FastRenderer.VisualElemen... (#888)
  [Android] Add disposed check on FastRenderers.LabelRenderer (#886)
  add disposed check on FastRenderers.FrameRenderer (#887)
  [iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
  [Xaml] move ValueConverterProvider to Core (#890)

@samhouts samhouts deleted the a117-rename branch Aug 15, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018

@samhouts samhouts added this to Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts removed this from Done in vNext+1 (master) Jun 26, 2018

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment