Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying AutomationProperties.LabeledBy by name #914

Merged
merged 2 commits into from Nov 13, 2017

Conversation

@StephaneDelcroix
Copy link
Member

StephaneDelcroix commented May 10, 2017

Description of Change

this

AutomationProperties.LabeledBy="label"

is now a shortcut for

AutomationProperties.LabeledBy="{x:Reference label}"

Bugs Fixed

/

API Changes

Moved:

  • Xamarin.Forms.Xaml.Internals.INameScopeProvider from Xaml to Core, with additional type forwarding for backward compat

Added:

  • class ReferenceTypeConverter

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@StephaneDelcroix

This comment has been minimized.

Copy link
Member Author

StephaneDelcroix commented Jun 1, 2017

see #959

@StephaneDelcroix StephaneDelcroix force-pushed the refTypeConverter branch from 596c684 to 50ce0c8 Nov 13, 2017
@StephaneDelcroix

This comment has been minimized.

Copy link
Member Author

StephaneDelcroix commented Nov 13, 2017

rebased (finally). waiting for a green build

@StephaneDelcroix StephaneDelcroix changed the title Allow specifying Accessibility.LabeledBy by name Allow specifying AutomationProperties.LabeledBy by name Nov 13, 2017
@StephaneDelcroix StephaneDelcroix merged commit 4ad4ff7 into master Nov 13, 2017
2 checks passed
2 checks passed
VSTS: Xamarin Forms Windows 1134363 Succeeded
Details
VSTS: Xamarin Forms Windows (PR Builds) Started PR process $(TriggeredBuildIds)
Details
@StephaneDelcroix StephaneDelcroix deleted the refTypeConverter branch Nov 13, 2017
@samhouts samhouts added the API-change label Apr 3, 2018
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Aug 23, 2019
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.