This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
label
Feb 4, 2020
PureWeen
reviewed
Feb 5, 2020
PureWeen
requested review from
hartez and
PureWeen
and removed request for
StephaneDelcroix
February 5, 2020 05:26
PureWeen
suggested changes
Feb 5, 2020
{ | ||
var weakEvent = new WeakEventListener<OrientationStateTrigger, object, EventArgs>(this) | ||
{ | ||
OnEventAction = (instance, source, eventArgs) => OnSizeChanged(source, eventArgs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeviceInfo implements INPC so you can just subscribe to that and watch for Orientation changes
...Forms.Controls/GalleryPages/VisualStateManagerGalleries/StateTriggersDirectlyOnElements.xaml
Outdated
Show resolved
Hide resolved
PureWeen
suggested changes
Feb 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some Core.UnitTests as well?
jsuarezruiz
removed
the
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
label
Feb 5, 2020
@PureWeen I have added some unit tests. |
PureWeen
suggested changes
Feb 5, 2020
jsuarezruiz
force-pushed
the
adaptivetriggers
branch
from
February 6, 2020 09:00
5163fd3
to
2c7c181
Compare
Thank you for making IsActive a public getter instead of protected. I'd like to propose you also add an event for when it changes. The reason for that is to be able to make composite state triggers. I state my case for that in this design issue: |
PureWeen
force-pushed
the
adaptivetriggers
branch
from
February 7, 2020 21:17
84c4d7c
to
ed2186e
Compare
samhouts
approved these changes
Feb 7, 2020
PureWeen
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
An AdaptiveTrigger provides an easy way to set the threshold (also called 'breakpoint') where a state is applied. A VisualState defines property values that are applied to an element when it’s in a particular state. You group visual states in a VisualStateManager that applies the appropriate VisualState when the specified conditions are met.
Example:
Issues Resolved
API Changes
Added:
In Xamarin.Forms.DualScreen:
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
AdaptiveTrigger
DeviceStateTrigger
Running on Android
Running on iOS
OrientationStateTrigger
CompareStateTrigger
DualScreenStateTrigger
Testing Procedure
Launch Core Gallery and navigate to the VisualStateManager samples. Here, can find new samples related with Adaptive Triggers.
PR Checklist