New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[previewer] make sure we do not crash even if the previewer doesn't s… #946

Merged
merged 2 commits into from Jun 1, 2017

Conversation

Projects
None yet
5 participants
@StephaneDelcroix
Member

StephaneDelcroix commented May 30, 2017

Description of Change

Make sure we do not crash even if the previewer doesn't sets the flag. This used to work, but somehow regressed when the previewer started to use the XamlLoader API...

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix requested a review from alanmcgovern May 30, 2017

@jassmith jassmith self-requested a review May 30, 2017

get { return xamlFileProvider; }
internal set {
xamlFileProvider = value;
//¯\_(ツ)_/¯ the previewer forgot to set that bool

This comment has been minimized.

@alanmcgovern

alanmcgovern May 30, 2017

Contributor

😢

@alanmcgovern

alanmcgovern May 30, 2017

Contributor

😢

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix May 31, 2017

Member

@jassmith tests are fixed

Member

StephaneDelcroix commented May 31, 2017

@jassmith tests are fixed

@StephaneDelcroix StephaneDelcroix merged commit 6e732fb into master Jun 1, 2017

8 checks passed

Android-UITests-Stable Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
Android-UITests-Stable-LegacyRenderers Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 (Legacy Rende…
Details
OSX-Debug-Stable Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-Stable Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3791, ignored: 10
Details
Windows-Release-Stable Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Release Unit Tests : Tests passed: 3791, ignored: 10
Details
iOS10-UITests-Stable Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-Stable Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Running
Details
iOS9-UITests-Stable Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-bz56895 branch Jun 1, 2017

StephaneDelcroix added a commit that referenced this pull request Jun 1, 2017

[previewer] make sure we do not crash even if the previewer doesn't s… (
#946)

* [previewer] make sure we do not crash even if the previewer doesn't sets the flag

* make the tests pass

StephaneDelcroix added a commit that referenced this pull request Jun 1, 2017

[previewer] make sure we do not crash even if the previewer doesn't s… (
#946)

* [previewer] make sure we do not crash even if the previewer doesn't sets the flag

* make the tests pass

samhouts added a commit that referenced this pull request Jul 25, 2017

[previewer] make sure we do not crash even if the previewer doesn't s… (
#946)

* [previewer] make sure we do not crash even if the previewer doesn't sets the flag

* make the tests pass

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request Jul 28, 2017

Merge branch '2.3.5' into ios-fastrenderers
* 2.3.5:
  [UWP] Fixes for usage of XF with .net native toolchain (#1024)
  [UWP] Make sure to update HitTestVisible when IsEnable changes (#1015)
  [Android] Dispose check before setting properties on Button (#1013)
  Add missing member variable to FormsApplicationActivity
  Fix NRE when background color of button set in FormsApplicationActivity (#1010)
  Fix border on android buttons  (#941)
  [iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (#994)
  Set the Id field for Android Views created by Forms #1004
  Fix build
  Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (#961)
  [Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (#915)
  Remove debug outputs (#1008)
  Add check for instance of UITableView (#885)
  [XamlC] fix release builds of Xaml Unit Tests
  Dispose check on ButtonRenderer (#975)
  [previewer] make sure we do not crash even if the previewer doesn't s… (#946)
  [XamlC] fix build
  Remove VisualElement finalizer (#918)
  [XamlC] process symbols if DebugType is set (#925)

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment