This repository was archived by the owner on May 1, 2024. It is now read-only.
Implement icon tint color effect - #516
Merged
Gerald Versluis (jfversluis) merged 10 commits intoOct 31, 2020
Merged
Conversation
# Conflicts: # XamarinCommunityToolkitSample/ViewModels/Effects/EffectsGalleryViewModel.cs
Contributor
Author
|
I'm still working on the iOS implementation. Hope to get this pushed today, but otherwise somewhere next week. |
John Bijsterbosch (jBijsterboschNL)
changed the title
…w EffectIds constant
Contributor
Author
|
Darn incoming commits... 😛 |
John Bijsterbosch (jBijsterboschNL)
marked this pull request as ready for review
October 30, 2020 20:07
Andrei (AndreiMisiukevich)
left a comment
Andrei (AndreiMisiukevich)
left a comment
Contributor
There was a problem hiding this comment.
Could you fix the code format a little?)
Typically we don't use parentheses in one-line operator's bodies
Contributor
Author
Hi Andrei (@AndreiMisiukevich), of course no problem, my bad. I'm used to use braces even white single line statements, same for not using a lambda for single line methods. So sometimes I forget, which isn't consistent 😉 thanks for checking this! I've re-checked my entire code change, could you review again? 😃 |
John Bijsterbosch (jBijsterboschNL)
requested a review
from Andrei (AndreiMisiukevich)
October 31, 2020 06:08
Gerald Versluis (jfversluis)
approved these changes
Oct 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Implemented IconTintColorEffect for iOS and Android to set a tint color to Image and ImageButton controls.
Bugs Fixed
API Changes
Added TintColor attached property for Image and ImageButton controls. When setting this attached property, the IconTintColorEffect is added to the control. The effect is implemented for the iOS and Android platforms.
Behavioral Changes
N/A
PR Checklist