Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'HttpClient' sample #298

Merged
merged 5 commits into from Nov 7, 2018
Merged

Update 'HttpClient' sample #298

merged 5 commits into from Nov 7, 2018

Conversation

mykyta-bondarenko
Copy link
Contributor

@mykyta-bondarenko mykyta-bondarenko commented Nov 7, 2018 •
edited

I've found that this sample is too old and isn't displayed properly on the latest devices. So I have decided to update it and it's done now.

  • re-created project (new structure)
  • use storyboards
  • updated classes dependencies and hierarchy
  • updated readme and screenshots

@mykyta-bondarenko
Copy link
Contributor Author

Before it was like this:
simulator screen shot - iphone 8 plus - 2018-11-07 at 16 29 21

conceptdev
conceptdev approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@conceptdev conceptdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @mykyta-bondarenko-gl

@conceptdev conceptdev merged commit 354f322 into master Nov 7, 2018
@conceptdev conceptdev deleted the update-http-client-sample branch November 7, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conceptdev conceptdev conceptdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mykyta-bondarenko @conceptdev