[Java.Interop] optimize JniTypeManager.AssertSimpleReference() #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed `dotnet trace` output was showing:
21.28ms (0.45%) java.interop!Java.Interop.JniRuntime.JniTypeManager.AssertSimpleReference(string,string)
This code path was introduced by a new feature in 1f27ab5.
For now, I think we can rewrite this to use the `char` overload of
`IndexOf`, as well as the regular indexer on `string`.
After these changes, I get a better time:
1.21ms java.interop!Java.Interop.JniRuntime.JniTypeManager.AssertSimpleReference(string,string)
We may have just *moved* the location that ICU is loaded, but this
change is good regardless.
|
The next place that is loading ICU, is back to .NET 6 behavior:
Probably not avoidable: |
grendello
approved these changes
Jun 29, 2022
|
That feels like dotnet/runtime should be fixed. |
src/Java.Interop/Java.Interop/JniTypeSignatureAttribute.cs: JniRuntime.JniTypeManager.AssertSimpleReference (simpleReference, nameof (simpleReference)); Not all codepaths use `jniSimpleReference`. Use `argumentName` for the argument name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed
dotnet traceoutput was showing:This code path was introduced by a new feature in 1f27ab5.
For now, I think we can rewrite this to use the
charoverload ofIndexOf, as well as the regular indexer onstring.After these changes, I get a better time:
We may have just moved the location that ICU is loaded, but this
change is good regardless.