New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] Designer items should be const for apps. #1657

Merged
merged 2 commits into from May 9, 2018

Conversation

Projects
None yet
2 participants
@dellis1972
Contributor

dellis1972 commented May 8, 2018

The ManagedResourceParser was not taking into account the fact
that the app should be using const not static for the
resource fields.

dellis1972 added some commits May 8, 2018

[Xamarin.Android.Build.Tasks] Designer items should be const for apps.
The `ManagedResourceParser` was not taking into account the fact
that the app should be using `const` not `static` for the
resource fields.

@jonpryor jonpryor merged commit 5f3a177 into xamarin:master May 9, 2018

3 checks passed

Ubuntu PR Build Build finished. No test results found.
Details
license/cla All CLA requirements met.
Details
macOS PR Build Build finished. 37227 tests run, 906 skipped, 0 failed.
Details

dellis1972 added a commit that referenced this pull request May 25, 2018

[Xamarin.Android.Build.Tasks] Designer items should be const for apps. (
#1657)

`ManagedResourceParser` was not taking into account the fact that the
app should be using `const` not `static` for the resource fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment