New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to mono:2018-08 #2048

Merged
merged 43 commits into from Dec 6, 2018

Conversation

Projects
None yet
5 participants
@directhex
Member

directhex commented Aug 8, 2018

No description provided.

@jonpryor

This comment has been minimized.

Contributor

jonpryor commented Aug 13, 2018

The macOS PR Build fails after 10 minutes:

  /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/external/mono/mono/metadata/w32file-unix.c:2424:66: error: use of undeclared identifier 'COPYFILE_CLONE'

EgorBo added some commits Oct 4, 2018

Merge branch 'master' into mono-2018-08
# Conflicts:
#	.gitmodules
#	Configuration.props
#	build-tools/dependencies/dependencies.projitems
#	external/mono

@EgorBo EgorBo referenced this pull request Oct 4, 2018

Merged

[2018-08] Bump corefx #10979

@marek-safar marek-safar referenced this pull request Oct 4, 2018

Open

2018-08 Mono Release #9901

1 of 13 tasks complete

EgorBo and others added some commits Oct 5, 2018

Merge branch 'master' into mono-2018-08
# Conflicts:
#	.gitmodules
#	Configuration.props
#	build-tools/dependencies/dependencies.projitems
#	external/llvm
#	external/mono
Bump to mono/2018-08/04a6e829
Commit list for mono/mono:

* mono/mono@04a6e82 [2018-08] Bump xunit (#11085)
* mono/mono@f001e69 [2018-08] Bump msbuild (#11087)
* mono/mono@7001d39 Always use InvariantCulture calendars in X509Certificate on Mobile

Diff: mono/mono@e257971...04a6e82

luhenry and others added some commits Oct 12, 2018

Bump to mono/2018-08/7805ccc4
Commit list for mono/mono:

* mono/mono@7805ccc [sdks] Fix llvm-llvm32 build (#11117)

Diff: mono/mono@04a6e82...7805ccc
Bump to mono/2018-08/657f915e
Commit list for mono/mono:

* mono/mono@657f915 [2018-08] [sdks] Create archive targets for pre-building on CI (#10932)
* mono/mono@bd1f64a [sdks] Add cmake toolchain file for LLVM MXE builds (#11055)

Diff: mono/mono@7805ccc...657f915
Merge branch 'master' into mono-2018-08
# Conflicts:
#	external/mono
Bump to mono/2018-08/2712292c
Commit list for mono/mono:

* mono/mono@2712292 [sdks] Add Groovy script to build the SDKs archives for the products (#11192)
* mono/mono@839f49d [sdks] futimens and futimes symbols are missing on anything earlier than 10.13 (#11176)

Diff: mono/mono@657f915...2712292

luhenry and others added some commits Oct 18, 2018

Bump to mono/2018-08/010e741b
Commit list for mono/mono:

* mono/mono@010e741 [2018-08] Crash Reporter V2  (#11161)
* mono/mono@ec1a736 [corlib] Ensure that Console Streams are thread-safe

Diff: mono/mono@a9b1acb...010e741
Bump to mono/2018-08/bc9d709e
Commit list for mono/mono:

* mono/mono@bc9d709 [sdks] Package what's missing for XA (#11256)
* mono/mono@31a6b87 [pipeline] Ensure only 1 build per-product is executed per-node (#11249)
* mono/mono@4b343e9 [interp] Implement interpreter entry trampolines on amd64 (#10978) (#11164)
* mono/mono@2bc1ed0 [aot] Ensure shared got entries are initialized before loading methods (#11226)

Diff: mono/mono@010e741...bc9d709
@marek-safar

This comment has been minimized.

Contributor

marek-safar commented Oct 26, 2018

@jonpryor is this ready to be merged?

The API change in System.Security.Cryptography.Pkcs.ContentInfo is not breaking change as the type is sealed

Bump to mono/2018-08/0522076f
Commit list for mono/mono:

* mono/mono@0522076 [interp] throw overflow exception when {float,double}.NaN is converted to an int type (#11411)
* mono/mono@6034c58 [interp] enable more BCL tests (#11399)
* mono/mono@aebff6c [SDKS, LLVM] Disable detection and use of libxml2 (#11340)
* mono/mono@818a27a [2018-08] [aot] add unbox_arbitrary_trampoline for fullaot/interp mixed mode (#11363)
* mono/mono@b5e8de9 [2018-08][corlib] Adds back accidentaly removed legacy COM API to Binder (#11368)
* mono/mono@205b812 [tests] lower recursion depth of PerformNoPinAction (#11323)
* mono/mono@c2c764d [2018-08] Replace mono_object_get_class with mono_object_class to avoid gc transitions. (#11338)
* mono/mono@b778499 [wasm] Add missing include (#11337)

Diff: mono/mono@b7ad1c6...0522076
@marek-safar

This comment has been minimized.

Contributor

marek-safar commented Oct 30, 2018

@jonpryor could you please confirm the readiness of this PR from your side?

luhenry added some commits Nov 2, 2018

Bump to mono/2018-10/3c2b25ce
Commit list for mono/mono:

* mono/mono@3c2b25c [System]`lock` protect `SystemCertificateProvider.EnsureInitialized()`.
* mono/mono@5fedefe [tests] reduce recursion depth
* mono/mono@53a21a0 [crash] Fix async setting for crash reporter
* mono/mono@04bdf88 [2018-08] [crash] Fix merp invocation (#11468)
* mono/mono@8df60a2 [delegates] do not use CEE_CALLVIRT for non-virtual methods (#11451)
* mono/mono@d90fbe3 [llvm] Fix passing vtypes received by value as arguments, they need to be copied. Fixes mono/mono#11378. (#11429)
* mono/mono@ea740d2 Disable hybrid suspend default for 2018-08

Diff: mono/mono@0522076...3c2b25c
Bump to mono/2018-08/32d4b6f2
Commit list for mono/mono:

* mono/mono@32d4b6f [llvm] bump for armhf callingconv fix (#11609)
* mono/mono@925e0c0 [ios] remove DISABLE_POLICY_EVIDENCE (#11581)
* mono/mono@65cd16c Bump roslyn-binaries submodule to pull in System.Xml.dll file name fix in vbc.rsp (#11573)
* mono/mono@b5891e2 [ci] Fix Windows .msi build
* mono/mono@d4d1d1e [bcl] avoid false pinning in GCTest (#11536)
* mono/mono@3837f0c [interp] accept typed-by-ref as return type from a JIT call (#11533)
* mono/mono@2e5c0d8 [interp] transform delegate invoke in method body too (#11551)
* mono/mono@60c21be [ci] Switch to new syntax of Azure Storage plugin

Diff: mono/mono@3c2b25c...32d4b6f
Bump to mono/2018-08/23f2024a
Commit list for mono/mono:

* mono/mono@23f2024 [2018-08] Fix Encoding serialization issue (#11807)
* mono/mono@414cafa [interp] Don't include internal frames in stack trace (#11793)
* mono/mono@68746a8 [ci] Disable log compression in pipeline builds for now - second attempt
* mono/mono@1f62222 [mini] use AOT trampolines in interp mixed mode (#11781)
* mono/mono@d0184b6 [ci] Disable log compression in pipeline builds for now
* mono/mono@a4c0912 [loader] ignore 'internalcall' impl attribute on 'abstract' methods
* mono/mono@7b9d9b3 [arm64] Fix passing r4/r8 arguments on the stack in the gsharedvt trampoline.
* mono/mono@e3a4484 [2018-08] Add .NET 4.7.2 reference assemblies (#11733)
* mono/mono@99b6da7 [interp] attempt to intrinsify again after a method is resolved regarding generics (#11717)
* mono/mono@2f57669 [2018-08] [aot] image is usable without debug flag when interpreter is used (#11709)
* mono/mono@0206338 [2018-08] [crash] Remove duplicated il_offset (#11702)
* mono/mono@b20dad6 [runtime] Fix the size calculation in mono_debug_add_method (). (#11687)
* mono/mono@0f81533 [arm64] Pass small stack args correctly on linux. Fixes pinvoke.exe with llvm+full aot. (#11682)
* mono/mono@81f3c47 [2018-08] Fix starting process with empty environment incorrectly inherits all variables (#11645)
* mono/mono@6a9ee13 [ci] Clean acceptance-tests/external before build
* mono/mono@b8ebc79 [ios] cosmetic fix for WatchOS Makefile (#11668)

Diff: mono/mono@32d4b6f...23f2024

jonpryor added a commit to xamarin/xamarin-android-api-compatibility that referenced this pull request Dec 5, 2018

Update BCL assemblies for mono/mono:2018-08@23f2024a breakage
Context: xamarin/xamarin-android#2048
Context: https://jenkins.mono-project.com/job/xamarin-android-pr-builder-debug/38/API_20Compatibility_20Checks/

The mono/mono:2018-08@23f2024a bump introduces "breaking" changes to
`System.Security.dll`: the
`System.Security.Cryptography.Pkcs.ContentInfo` lost its finalizer:

	<h3>Type Changed: System.Security.Cryptography.Pkcs.ContentInfo</h3>
	<p>Removed method:</p>
	<pre>
	  <span class='removed removed-method breaking' data-is-breaking>protected override void ~ContentInfo ();</span>
	</pre>

Removal of `virtual` method `override`s is not a breaking change,
and finalizers are overrides of `object.Finalize()`.

Remove the `ContentInfo.~ContentInfo()` finalizer declaration from
`reference/System.Security.xml` so that this "breakage" is no
longer reported.

jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Dec 5, 2018

Bump to xamarin/xamarin-android-api-compatibility@73d45d0
Context: xamarin#2048

Remove the `System.Security.Cryptography.Pkcs.ContentInfo` finalizer
so that the mono/mono/2018-08 bump doesn't report its removal as
API breakage.

jonpryor added a commit that referenced this pull request Dec 5, 2018

Bump to xamarin/xamarin-android-api-compatibility@73d45d0 (#2488)
Context: #2048

Remove the `System.Security.Cryptography.Pkcs.ContentInfo` finalizer
so that the mono/mono/2018-08 bump doesn't report its removal as
API breakage.

@jonpryor jonpryor merged commit 3897e86 into master Dec 6, 2018

1 of 5 checks passed

Ubuntu PR Build Build finished. No test results found.
Details
Xamarin.Android (Windows) #2245266 failed
Details
macOS PR Debug Build Build finished. 108969 tests run, 869 skipped, 0 failed.
Details
macOS PR Release Build Build finished. 216746 tests run, 1728 skipped, 1 failed.
Details
license/cla All CLA requirements met.
Details
@luhenry

This comment has been minimized.

Member

luhenry commented Dec 6, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment