New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[samples] use $(DebugType) portable #2492

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@jonathanpeppers
Contributor

jonathanpeppers commented Dec 5, 2018

In 1fb7983, a new HelloLibrary.csproj was added, but it had some
settings that cause pdb2mdb to run:

<DebugType>full</DebugType>
...
<DebugType>pdbonly</DebugType>

I switched the "Hello World" projects to use $(DebugType) portable,
so that portable pdb files are always generated as part of their
build.

This way when profiling builds on Windows, I don't have to account for
the <ConvertDebuggingFiles/> MSBuild task taking time.

[samples] use $(DebugType) portable
In 1fb7983, a new `HelloLibrary.csproj` was added, but it had some
settings that cause `pdb2mdb` to run:

    <DebugType>full</DebugType>
    ...
    <DebugType>pdbonly</DebugType>

I switched the "Hello World" projects to use `$(DebugType)` `portable`,
so that portable pdb files are always generated as part of their
build.

This way when profiling builds on Windows, I don't have to account for
the `<ConvertDebuggingFiles/>` MSBuild task taking time.

@jonathanpeppers jonathanpeppers requested a review from dellis1972 Dec 5, 2018

@jonathanpeppers jonathanpeppers requested a review from jonpryor as a code owner Dec 5, 2018

@jonpryor jonpryor merged commit c797a45 into xamarin:master Dec 6, 2018

3 checks passed

Ubuntu PR Build Build finished. No test results found.
Details
license/cla All CLA requirements met.
Details
macOS PR Release Build Build finished. 208626 tests run, 1753 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment