use mono/linker sources to build the linker #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- recently the linker was moved out of mono to a standalone repository, so update XA to use the sources from the new location
radekdoulik
force-pushed
the
use-mono-linker-repo
branch
from
c272cb0
to
b3a7702
Compare
radical
pushed a commit
that referenced
this pull request
May 8, 2018
While reviewing cd50ef2 it occurred to us that `JniNativeMethodRegistrationArguments` is a *`struct`*. As such, it has a default constructor, which `null`-initializes things. Which in turn means that *all* properties, at present, can be `null`. Thus, a question: *Is this a problem*? Specifically, would it be a problem if `JniNativeMethodRegistrationArguments.Registrations` were `null`? Turns Out™ that there are many places which assume that it is *not* `null`, such as `JavaProxyObject.RegisterNativeMembers()`. Update `JniNativeMethodRegistrationArguments.Registrations` so that when `_registrations` is `null` we throw `InvalidOperationException`. This will avoid `NullReferenceExceptions`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repository, so update XA to use the sources from the new location