Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] improve InvalidAndroidResource failure #3414

Merged

Conversation

@jonathanpeppers
Copy link
Member

jonathanpeppers commented Jul 30, 2019

Context: https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-release/1744/testReport/Xamarin.Android.Build.Tests.IncrementalBuildTest/InvalidAndroidResource/_True____Release/

IncrementalBuildTest.InvalidAndroidResource is sometimes failing on
Jenkins with:

Build should have succeeded.
  Expected: True
  But was:  False

If we set ThrowOnBuildFailure back to True before this assertion,
we will get a proper build log in the error message.

Context: https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-release/1744/testReport/Xamarin.Android.Build.Tests.IncrementalBuildTest/InvalidAndroidResource/_True____Release/

`IncrementalBuildTest.InvalidAndroidResource` is sometimes failing on
Jenkins with:

    Build should have succeeded.
      Expected: True
      But was:  False

If we set `ThrowOnBuildFailure` back to `True` before this assertion,
we will get a proper build log in the error message.
@jonathanpeppers jonathanpeppers requested a review from dellis1972 as a code owner Jul 30, 2019
@jonathanpeppers jonathanpeppers merged commit bf514b2 into xamarin:master Jul 31, 2019
8 of 10 checks passed
8 of 10 checks passed
Ubuntu PR Release Pipeline Build Build finished. No test results found.
Details
macOS PR Release Pipeline Build Build finished. 356387 tests run, 1897 skipped, 3 failed.
Details
Xamarin.Android Build #merge-966c778e7e03a80301a6948573031e12ceee8178-1 succeeded
Details
Xamarin.Android (Mac Build) Mac Build succeeded
Details
Xamarin.Android (Prepare bundle) Prepare bundle succeeded
Details
Xamarin.Android (Test APK Instrumentation) Test APK Instrumentation succeeded
Details
Xamarin.Android (Test Designer Mac) Test Designer Mac succeeded
Details
Xamarin.Android (Test Designer Windows) Test Designer Windows succeeded
Details
Xamarin.Android (Windows Build and Test) Windows Build and Test succeeded
Details
license/cla All CLA requirements met.
@jonathanpeppers jonathanpeppers deleted the jonathanpeppers:invalidandroidresource branch Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.