Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Prepare BuildProcess for sync to docs.microsoft.com #3417

Merged
merged 3 commits into from Aug 1, 2019

Conversation

@brendanzagaeski
Copy link
Member

brendanzagaeski commented Jul 30, 2019

Bring in the **NOTE:** to [!NOTE] syntax change from docs.microsoft.com:

https://github.com/MicrosoftDocs/xamarin-docs/commit/ccb1a1252ca5a70d82f2e75c6d41f6d0eab97572

Proofread the new BuildProcess items.

Move an item to keep the list in alphabetical order.

Bring in the `**NOTE:**` to `[!NOTE]` syntax change from docs.microsoft.com:

    MicrosoftDocs/xamarin-docs@ccb1a12
Proofread the new BuildProcess items.
Move an item to keep the list in alphabetical order.
@brendanzagaeski brendanzagaeski requested a review from jonpryor as a code owner Jul 30, 2019
@@ -555,7 +562,7 @@ when packaging Release applications.
* `$(AndroidUseApkSigner)` is `False`.
* `$(AndroidCreatePackagePerAbi)` is `False`.

[apk]: https://en.wikipedia.org/wiki/Android_application_package]
[apk]: https://en.wikipedia.org/wiki/Android_application_package

This comment has been minimized.

Copy link
@brendanzagaeski

brendanzagaeski Jul 30, 2019

Author Member

There is also a brief description of APK files at the beginning of this same document in the #overview and #application-packages sections that could be another option for this link, in case linking to Wikipedia is unusual. The Wikipedia article itself links to https://developer.android.com/guide/components/fundamentals, which has a brief two sentence description of APK files. It looks like that is indeed the main place on developer.android.com that defines what an APK file is, but it is quite brief. For example, it doesn't mention that an APK file uses the .zip file format.

A related idea could be to update the #application-packages section to include a bit of information about the new Android App Bundle format.

We don't have to decide on any of that for this PR necessarily. We can always come back to it in the future.

@jonpryor jonpryor merged commit fdc8dda into xamarin:master Aug 1, 2019
8 of 10 checks passed
8 of 10 checks passed
Ubuntu PR Release Pipeline Build Build finished. No test results found.
Details
macOS PR Release Pipeline Build Build finished. 356387 tests run, 1897 skipped, 5 failed.
Details
Xamarin.Android Build #merge-61cc6d1e2fcdcb8b21ba89dc4d3dae8d7d1179fb-1 succeeded
Details
Xamarin.Android (Mac Build) Mac Build succeeded
Details
Xamarin.Android (Prepare bundle) Prepare bundle succeeded
Details
Xamarin.Android (Test APK Instrumentation) Test APK Instrumentation succeeded
Details
Xamarin.Android (Test Designer Mac) Test Designer Mac succeeded
Details
Xamarin.Android (Test Designer Windows) Test Designer Windows succeeded
Details
Xamarin.Android (Windows Build and Test) Windows Build and Test succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.