Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XM forcing provisioning with custom entitlements when Xcode does not #5061

Open
chamons opened this Issue Oct 31, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@chamons
Copy link
Member

chamons commented Oct 31, 2018

Steps to Reproduce

  1. Create new Xcode macOS project.
  2. Add custom entitlements
  3. Build and check signing. Provisioning not required:

screen shot 2018-10-31 at 9 20 06 am

  1. Create new XM project
  2. Add same custom entitlement file to signing settings
  3. Try to build. Get error stating that entitlements are required:

screen shot 2018-10-31 at 9 20 14 am

Expected Behavior

XM signing to match Xcode signing.

Actual Behavior

Signing requires differ.

Environment

https://gist.github.com/chamons/9283e9d56b1f4f5e51bce2edc19f5c6e

Build Logs

https://gist.github.com/chamons/886d38dd03ed558af70da69fc6bfe360

@spouliot spouliot added this to the Future milestone Oct 31, 2018

@spouliot

This comment has been minimized.

Copy link
Contributor

spouliot commented Jan 3, 2019

It's worth noting that, if you have a (Mac) provisioning profile, then it's possible to use None in the UI.

IOW the current code makes a difference between None (where no .provisionprofile file exists) and None (when the existing file(s) are simply ignored for the build)

@albilaga

This comment has been minimized.

Copy link

albilaga commented Jan 17, 2019

Any news when this is available? Will try to use without provisioning profile to submit rejected appstore submission again. Thanks

@spouliot

This comment has been minimized.

Copy link
Contributor

spouliot commented Jan 18, 2019

@albilaga there's an UI issue in VS Mac where you cannot select None without having a provisioning profile.

However you do not need to use it when signing your application, i.e. create a profile and then select None and it should be identical to what Xcode does. If not please provide us with a test case so we can investigate this further. Thanks!

@albilaga

This comment has been minimized.

Copy link

albilaga commented Jan 18, 2019

@spouliot you actually can’t do that. If you do that you actually still embed provisioning profile in mac.app. It is different with what XCode does when you use none in XCode it will not embed provisioning profile. You can try to Show Package Content in app that build with signing application bundle but with provisioning profile set to None. There is still embedded.provisionprofile inside the app which is different from xcode build app which there is no embedded.provisionprofile inside it

@albilaga

This comment has been minimized.

Copy link

albilaga commented Apr 3, 2019

Any update with this? My app still rejected because of this

@chamons

This comment has been minimized.

Copy link
Member Author

chamons commented Apr 12, 2019

I have not been able to reproduce an app rejection due to this.

Can you post the message and details?

@albilaga

This comment has been minimized.

Copy link

albilaga commented Apr 13, 2019

Yes. It is works right now. I also dunno what happen. I am just using VS for mac 2019. Anyway thanks for the concern

@chamons chamons closed this Apr 15, 2019

@chamons chamons reopened this Apr 15, 2019

@jstedfast

This comment has been minimized.

Copy link
Contributor

jstedfast commented Apr 15, 2019

Possible solution:

Edit Xamarin.Mac.Common.targets:

- <_RequireProvisioningProfile Condition="'$(CodesignEntitlements)' != ''">True</_RequireProvisioningProfile>
+ <_RequireProvisioningProfile Condition="'$(CodeSignProvision)' != ''">True</_RequireProvisioningProfile>
@jstedfast

This comment has been minimized.

Copy link
Contributor

jstedfast commented Apr 15, 2019

The above change will allow codesigning with custom entitlements w/o a provisioning profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.