[macos] Release mode AOT should delete dSYM files #2760
Conversation
chamons
commented
Sep 22, 2017
chamons
commented
- https://bugzilla.xamarin.com/show_bug.cgi?id=59647
- Also fix stand alone unit test running
- make run in tools/mmp uses different (faster) build system than full mmp tests
- There is no reasonable knob on the AOT process to not generate dSYM so delete after processing - AppStore complains if you ship bundles with dSYM fils present - https://bugzilla.xamarin.com/show_bug.cgi?id=59647
There was a problem hiding this comment.
I need more context.
XM should be able to ship a single .dSYM for an application built in release mode (just like we do for XI) since this is how symbolication works.
What you seems to be removed are several .dSYM files (not useful) but it's not clear if the main feature (a single one) works - and the title is scary since there's such a thing as a good, release, dSYM (directory)
|
So each invocation to mono --aot was creating a separate .dSYM for that specific AOTed assembly inside the MonoBundle folder. Example XMAppAOT.app/Contents/MonoBundle/System.dll.dylib.dSYM/ and those gave a customer the following error when submitting a bundle:
I don't know anything else about dSYM files and Xamarin.Mac, so i can't make comments on if that feature is/is not working. These specific files are spawned only by/during AOT. |
|
https://bugzilla.xamarin.com/show_bug.cgi?id=59701 I'll add "These specific files are spawned only by/during AOT." to the commit when I squash and commit. |
|
Build failure |
|
Test failure is "exec-link-keep-resources-2.log" which is fixed in master, after this PR was started. |
