[tests][security] Update TrustTest to run faster (without timeouts) #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original test was to cover both X509Certificate and X509Certiicate2 when using with SecTrust. However the code diverged over time. That and the different certificates used caused the `*2` tests to hit a time loop (designed to reduce incorrect errors randomly reported). We want to keep the "delay" logic for it's intended purpose - but it should not be needed normally. The tests have been refactored to reuse the same logic (between both types of certificates) which solve this (when used with the same certificates) Replace xamarin#3068
|
Build failure |
|
interesting failures :| |
…rent one (for 2) has different results between iOS 10.3 (and macOS 10.12) and iOS 11 - and this is not the goal of the test to check those differences
chamons
approved these changes
Dec 18, 2017
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original test was to cover both X509Certificate and X509Certiicate2
when using with SecTrust. However the code diverged over time. That and
the different certificates used caused the
*2tests to hit a timeloop (designed to reduce incorrect errors randomly reported).
We want to keep the "delay" logic for it's intended purpose - but it
should not be needed normally.
The tests have been refactored to reuse the same logic (between both
types of certificates) which solve this (when used with the same
certificates)
Replace #3068