New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d15-9][mmp] Add support for mono 5.18 by pulling in libmono-system-native.a #5328

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
7 participants
@chamons
Copy link
Member

chamons commented Dec 21, 2018

  • #5324
  • Patch tweaked over multiple commits in master so applied directly instead of cherry-pick
[mmp] Add support for mono 5.18 by pulling in libmono-system-native.a
- #5324
- Patch tweaked over multiple commits in master so applied directly instead of cherry-pick

@chamons chamons requested review from spouliot and rolfbjarne and removed request for spouliot Dec 21, 2018

@monojenkins

This comment has been minimized.

Copy link
Collaborator

monojenkins commented Dec 21, 2018

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@Aguilex

Aguilex approved these changes Jan 7, 2019

@@ -1352,6 +1352,13 @@ static int Compile ()

args.Append (StringUtils.Quote (lib)).Append (' ');

// libmono-system-native.a needs to be included if it exists in the mono in question
string libmonoNative = Path.Combine (libdir, "libmono-system-native.a");

This comment has been minimized.

@alanmcgovern

alanmcgovern Jan 8, 2019

Contributor

I just want to put this comment here too:

#5324 (comment)

This file has been renamed in newer mono releases, so if we're going to the effort of backporting support for this name, we should also add support for the other name. That will ensure we don't have to go through this procedure again.

A more complete justification/explanation is here: xamarin/designer#1351 (comment) / xamarin/designer#1351 (comment)

This comment has been minimized.

@chamons

chamons Jan 10, 2019

Member

Mono has said they will roll back the rename.

@chamons chamons removed the do-not-merge label Jan 10, 2019

@chamons chamons merged commit a4332c9 into xamarin:d15-9 Jan 10, 2019

2 checks passed

Build Build success. 21575 tests run, 811 skipped, 0 failed.
Details
license/cla All CLA requirements met.

@chamons chamons deleted the chamons:d15-9-mono-18-patch branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment