Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Branch: master
Commits on Jun 15, 2010
  1. create fb:friendpile, a legal-friendly version of fb:facepile

    yariv authored
    Summary:
    as the title says
    
    @Naitik, this isn't working and I'm not sure why. Any ideas? I see a 'Tag
    FB.XFBML.Friendpile was not found'
    error in the console.
    
    Test Plan:
    in http://fbrell.com/?server=www.yariv.dev238, entered
    <fb:friendpile></fb:friendpile>
    
    DiffCamp Revision: 123657
    Reviewed By: naitik
    CC: brent, naitik, davidrecordon, achao
    Tasks:
    #215544: Change "Facepile" name and tag to something else without "Face(s)"
    
    Revert Plan:
    OK
Commits on Jun 9, 2010
  1. JS component of the fb:login-button with iframe + perms fix.

    yariv authored
    Summary:
    see http://tools.intern.facebook.com/D121897.
    
    Test Plan:
    see http://tools.intern.facebook.com/D121897
    
    DiffCamp Revision: 121898
    Reviewed By: jcain
    CC: ahaugen, jcain, brent
    Tasks:
    #213799: login-button w/ faces (perms)
    
    Revert Plan:
    OK
  2. connect js component of render-in-iframe for fb:login-button

    yariv authored
    Summary:
    This allows the developer to pass render-in-iframe="true" to fb:login-button,
    to force the widget to render in an iframe.
    
    Test Plan:
    in http://fbrell.com/?server=www.yariv.dev238, entered <fb:login-button
    render-in-iframe="true"></fb:login>, and verified the button was rendered in an
    iframe with no faces. Also checked some of the existing configs of fb:login and
    fb:facepile to make sure they didn't break. (Btw, we really need to unit test
    this stuff.)
    
    DiffCamp Revision: 120838
    Reviewed By: brent
    CC: ahaugen, brent, yariv
    Tasks:
    #204567: create an iframe param for <fb:login-button>
    
    Revert Plan:
    OK
Commits on Jun 4, 2010
  1. @daaku

    auto refresh session every 20 minutes

    daaku authored
    Summary:
    adds logic to setup a timer to ping login_status every 20 minutes. we
    only do this if getLoginStatus() was invoked at least once. this ensures
    that applications that do not want to fetch sessions in JS will not
    get this timer. if the session will not expire, we do not setup a timer
    either.
    
    Test Plan:
    For testing, I reduced the timeout from 20 minutes to 30 seconds. Then
    tested that the timer is setup on page load, if a session is found, and
    on login, if a session is returned.
    
    DiffCamp Revision: 120550
    Reviewed By: wzhu
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, wzhu, selekman
    Revert Plan:
    OK
  2. @daaku

    fix m.js reference

    daaku authored
    Test Plan:
    None
    
    DiffCamp Revision: 117799
    Reviewed By: alpjor
    CC: platform-diffs@lists, alpjor
    Revert Plan:
    OK
Commits on Jun 2, 2010
  1. @daaku

    revert 251069

    daaku authored
    Test Plan:
    None.
    
    DiffCamp Revision: 119682
    Reviewed By: mwebber
    CC: platform-diffs@lists, mwebber, naitik
    Revert Plan:
    OK
  2. @ptarjan

    YUIdoc thinks the first param is the name

    ptarjan authored
    Summary:
    YUIdoc does slightly different things than our coding styles.
    This fix makes
    http://developers.facebook.com/docs/reference/javascript/FB.Canvas.setAutoResize
    have the right names in the parameter table
    
    Test Plan:
    no code changes
    
    DiffCamp Revision: 119773
    Reviewed By: naitik
    CC: lshepard, brent, naitik, mattwkelly, selekman
    Revert Plan:
    OK
Commits on Jun 1, 2010
  1. @ptarjan

    Fix various parts of the docs

    ptarjan authored
    Summary:
    Someone synced over my doc updates, so I guess I better put
    them in the code. I also removed all references to joey, and hopeuflly
    made all the links work.
    
    Test Plan:
    No code changes
    
    DiffCamp Revision: 119644
    Reviewed By: naitik
    CC: lshepard, brent, naitik, mattwkelly, selekman
    Revert Plan:
    OK
Commits on May 27, 2010
  1. @daaku

    Move facebook.com/facebook-widgets to facebook.com/badges

    daaku authored
    Summary:
    Goes along with http://tools.intern.facebook.com/D117046
    
    Test Plan:
    None.
    
    DiffCamp Revision: 118196
    Reviewed By: ahimel
    Commenters: mwebber
    CC: platform-diffs@lists, ahimel, mwebber
    Revert Plan:
    OK
Commits on May 26, 2010
  1. @daaku

    Add some lost docs back

    daaku authored
    Test Plan:
    None.
    
    DiffCamp Revision: 118231
    Reviewed By: brent
    CC: platform-diffs@lists, lshepard, brent, naitik, mattwkelly, selekman
    Revert Plan:
    OK
  2. @daaku

    doc updates

    daaku authored
    Summary:
    from D117915
    
    Test Plan:
    None.
    
    DiffCamp Revision: 118134
    Reviewed By: btaylor
    CC: platform-diffs@lists, btaylor, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
Commits on May 25, 2010
  1. @daaku

    fan height is a px property. closes #87

    daaku authored
    Summary:
    http://github.com/facebook/connect-js/issues#issue/87
    
    Test Plan:
    Before:
    http://fbrell.com/bugs/gh87-fan-height
    
    After:
    http://fbrell.com/bugs/gh87-fan-height?server=sb
    
    DiffCamp Revision: 117807
    Reviewed By: rhe
    CC: platform-diffs@lists, rhe
    Revert Plan:
    OK
  2. @daaku

    it's user_message_prompt not user_prompt_message. closes #63

    daaku authored
    Test Plan:
    None.
    
    DiffCamp Revision: 117803
    Reviewed By: brent
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
  3. @daaku

    fix popup position in IE

    daaku authored
    Test Plan:
    In any IE, trigger the login popup-
    
    Busted in prod:
    http://fbrell.com/
    
    Fixed after this:
    http://fbrell.com/?server=sb
    
    DiffCamp Revision: 117797
    Reviewed By: brent
    CC: platform-diffs@lists, lshepard, brent, naitik, mattwkelly, selekman
    Revert Plan:
    OK
Commits on May 24, 2010
  1. @ptarjan

    Don't use https for static resources

    ptarjan authored
    Summary:
    If an internal url uses https the outer frame is still using
    http, so we shouldn't base the protocol assumption on the internal frame
    url.
    
    If we do cross domain communication to an outer https url, then rethink
    this.
    
    Test Plan:
    Tested with an app of https://fbrell.com/ as the canvas endpoint. Correctly
    resized for sanbox code, but was fataling with currently deployed code
    
    DiffCamp Revision: 116653
    Reviewed By: naitik
    Commenters: mathewsb
    CC: ptarjan, lshepard, brent, mathewsb, naitik, mattwkelly, selekman
    Tasks:
    #212617: make the fbconnect never use https://
    
    Revert Plan:
    OK
Commits on May 21, 2010
  1. Choose larger default and min width when action="recommend"

    jcain authored
    Summary:
    Title says it all.  We're seeing some clipping of the
    small button when action is set to button_count and action is
    set to recomment.  90 pixels is just too short for Recommend.
    This doesn't address internationalization issues at all, but
    the client also has the ability to specify the width when typing
    out <iframe.. or <fb:like...
    
    Test Plan:
    Loaded www.jerrycain.com/Z100.html (directed at my
    sandbox) and confirmed the iframe widths were what I wanted them
    to be.
    
    DiffCamp Revision: 116910
    Reviewed By: naitik
    Commenters: cat
    CC: cat, naitik, zhen
    Revert Plan:
    OK
Commits on May 16, 2010
  1. @daaku

    indicate fbconnect and extern correctly

    daaku authored
    Summary:
    Required for http://tools.intern.facebook.com/D111875
    
    Test Plan:
    Look at the other diff.
    
    DiffCamp Revision: 111878
    Reviewed By: brent
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
Commits on May 15, 2010
  1. @ptarjan @daaku

    Add iframe resizing to connect-js library

    ptarjan authored daaku committed
    Summary:
    Uses the newly created /connect/canvas_proxy.php to send
    messages to the canvas that we are inside. The first use of these
    messages is setSize so the internal iframe can tell the external page
    what size it wants to be
    
    Test Plan:
    Created a test iframe app. Called both FB.Canvas.setSize() and
    FB.Canvas.startTimerToSizeToContent() and saw it grow to the right size.
    FBML apps aren't affected. Smart-resizing apps work as well (since I
    disable smart resizing when the other end calls setSize()).
    
    Tested on Chrome 5 + Firefox 3.5 on OSX.
    
    Test app here: http://apps.ptarjan.dev229.facebook.com/paul_app_test/resize
    
    DiffCamp Revision: 113392
    Reviewed By: naitik
    Commenters: mathewsb
    CC: ptarjan, lshepard, brent, mathewsb, naitik, mattwkelly, selekman
    Tasks:
    
    Revert Plan:
    OK
Commits on May 14, 2010
  1. @daaku

    handle existing query strings

    daaku authored
    Test Plan:
    http://www.naitik.dev575.snc1.facebook.com/fbconnect/tests/index.html?initialize&api&query%20string
    
    DiffCamp Revision: 113930
    Reviewed By: abanker
    Commenters: ptarjan
    CC: platform-diffs@lists, ptarjan, lshepard, brent, naitik, abanker,
    mattwkelly, selekman
    Revert Plan:
    OK
  2. @daaku

    luke changed his name

    daaku authored
    Test Plan:
    http://www.naitik.dev575.snc1.facebook.com/fbconnect/tests/index.html?xfbmltags%20module%3A%20fb%3Aprofile-pic
    
    DiffCamp Revision: 113957
    Reviewed By: lshepard
    CC: platform-diffs@lists, lshepard
    Revert Plan:
    OK
  3. @daaku

    remove broken/dead loader/component code

    daaku authored
    Test Plan:
    Ran the test suite.
    
    DiffCamp Revision: 113954
    Reviewed By: alpjor
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, alpjor, selekman
    Revert Plan:
    OK
  4. @daaku

    Default options to empty {}

    daaku authored
    Summary:
    API Key is not longer required.
    
    Test Plan:
    http://www.naitik.dev575.snc1.facebook.com/fbconnect/tests/index.html?initialize&api
    
    DiffCamp Revision: 113927
    Reviewed By: alpjor
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, alpjor, selekman
    Revert Plan:
    OK
Commits on May 13, 2010
  1. [joey] make joey use total_count, as we do in sharepro

    rhe authored
    Summary:
    it's currently using share_count
    
    Test Plan:
    http://fbrell.com/?server=www.rhe.devrs006
    <fb:like
    href="http://www.rottentomatoes.com/m/sherlock_holmes_2009/"></fb:like>
    <fb:share-button href="http://www.rottentomatoes.com/m/sherlock_holmes_2009/"
    type="button_count"></fb:share-button>
    
    Confirmed joey matches sharepro numbers.
    
    DiffCamp Revision: 113992
    Reviewed By: naitik
    CC: platform-diffs@lists, ahaugen, naitik
    Revert Plan:
    ok
  2. @daaku

    format=json-strings to handle 64 bit ints

    daaku authored
    Test Plan:
    http://fbrell.com/fb.api/friends has ints.
    http://fbrell.com/fb.api/friends?server=sb has strings.
    
    DiffCamp Revision: 113511
    Reviewed By: rhe
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
Commits on May 10, 2010
  1. @daaku

    fix typoo

    daaku authored
    Test Plan:
    No error on http://fbrell.com/?server=sb anymore.
    
    DiffCamp Revision: 112844
    Reviewed By: wzhu
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, wzhu, selekman
    Revert Plan:
    OK
Commits on May 7, 2010
  1. @daaku

    Custom XD Fragment and cleanup

    daaku authored
    Summary:
    CNN & Amazon are asking for a custom XD Fragment URL. Generally, there
    is one case where the Fragment transport fails -- when there is
    background audio/video on the page, loading it in the iframe can cause
    it to be play over there as well resulting in double audio streams
    (video part would be hidden).
    
    I've given postMessage the highest priority, but a custom channelUrl
    will be prefered over Flash, where as without a custom channelUrl, we'll
    still prefer Flash to reusing the current page.
    
    I've also explicitly not documented the param in FB.init() for now, as I
    think it will be confusing.
    
    The channel file itself just needs to contain this line:
    
      <script src="http://connect.facebook.net/en_US/all.js"></script>
    
    We could also suggest this URL instead, which results in a much smaller
    JS file, but I'm not going to because the one above should already be
    cached:
    
      http://connect.facebook.net/en_US/xd.js
    
    Test Plan:
    Working on adding tests..
    
    DiffCamp Revision: 112249
    Reviewed By: wzhu
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, wzhu, selekman
    Tasks:
    
    Revert Plan:
    OK
  2. Don't animate Connect Bar after the first call

    alpjor authored
    Test Plan:
    tested in my sandbox.
    http://alpjor.com/test2.html
    
    verified that animation only happens on the first call.
    
    DiffCamp Revision: 109794
    Reviewed By: naitik
    CC: ahaugen, naitik
    Tasks:
    #198934
    #200432
    
    Revert Plan:
    OK
  3. Add api-read support to joey.

    Arthur Rudolph authored
    Summary:
    We only list a small number of calls in a micro-optimization to keep
    transmission size down (though I didn't actually measure this).
    
    Test Plan:
    test page that makes an api call in the whitelist and not in the
    whitelist; still works, and see that it hits the right endpoint in each
    case.  UTs, but they only touch this obliquely (i.e., you can see that they
    now hit api-read for the non-graph endpoints).
    
    DiffCamp Revision: 107997
    Reviewed By: naitik
    Commenters: brent
    CC: arudolph, lshepard, brent, naitik, mattwkelly, selekman
    Revert Plan:
    Ok
Commits on May 3, 2010
  1. @daaku

    remove old api cruft

    daaku authored
    Summary:
    no actual code change. just moved api_graph.js to api.js. this is
    already what production is doing. this will also make the generated docs
    accurate
    
    Test Plan:
    http://fbrell.com/fb.api/graph-me?server=sb
    
    DiffCamp Revision: 108445
    Reviewed By: lshepard
    CC: platform-diffs@lists, lshepard, brent, mattwkelly, selekman
    Revert Plan:
    OK
Commits on Apr 30, 2010
  1. @daaku

    New Live Stream Box: Add post to profile setting to JS

    twhitnah authored daaku committed
    Summary:
    Adding this setting to the XFBML tag
    
    Task ID: #
    
    Blame Rev:
    
    Reviewed By: naitik
    
    CC:
    
    Test Plan:
    1. Confirm that changing the setting in the XFBML tag changes the
    behaviour in the iframe
    
    Revert Plan:
    
    Tags:
    
    DiffCamp Revision: 109785
Commits on Apr 27, 2010
  1. Better Top Margin detection for Connect Bar

    alpjor authored
    Summary:
    This corrects a bug that yelp reported where the connect bar wasn't animating
    the page topMargin far enough. This diff adds better top margin detection to
    browsers that support it (non ie7, ie6).
    
    Test Plan:
    tested in my sandbox with all browsers
    http://alpjor.com/test2.html
    
    DiffCamp Revision: 109482
    Reviewed By: naitik
    CC: ahaugen, naitik
    Tasks:
    #198934
    
    Revert Plan:
    OK
  2. @daaku

    auto resize

    daaku authored
    Test Plan:
    None.
    
    DiffCamp Revision: 109312
    Reviewed By: julie
    CC: platform-diffs@lists, julie
    Revert Plan:
    OK
Commits on Apr 26, 2010
  1. Fix Links in connect bar in Safari

    alpjor authored
    Summary:
    Safari seems to fail in following outbound links in the connect bar unless the
    user has clicked another element in the page. This works around the behavior
    
    Test Plan:
    Tested in my sandbox:
    http://alpjor.com/test2.html
    
    in all browsers
    
    DiffCamp Revision: 109139
    Reviewed By: naitik
    CC: mvernal, ahaugen, naitik
    Tasks:
    #198934
    
    Revert Plan:
    OK
  2. Remove the logo from the connect bar

    alpjor authored
    Summary:
    people want to try text now.
    
    Test Plan:
    tested in my sandbox:
    http://alpjor.com/test2.html
    
    DiffCamp Revision: 109078
    Reviewed By: naitik
    CC: mvernal, ahaugen, naitik
    Tasks:
    #198480
    
    Revert Plan:
    OK
Commits on Apr 25, 2010
  1. @daaku

    fix double iframe reload

    daaku authored
    Test Plan:
    Charles to redirect JS SDK to sanbox and tested here:
    http://developers.facebook.com/docs/reference/plugins/login
    
    DiffCamp Revision: 108959
    Reviewed By: mvernal
    CC: platform-diffs@lists, mvernal
    Tasks:
    #199154
    
    Revert Plan:
    OK
Something went wrong with that request. Please try again.