New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab introduced soft delete of projects and groups #782
Comments
If I read it correctly, there now is a |
I asked for some help from Gitlab: https://gitlab.com/gitlab-org/gitlab/issues/33257#note_296585615 |
Maybe good to have the discussion there, but not what kind of help you mean? Adding the |
@svanharmelen if it is clear to you what the response structure and fields are for a delete request of a project or group, then no additional help is needed. If not, then it is mainly my request to the Gitlab people to help us out to clarify how we can detect the Nevertheless, are you able to implement the |
@svanharmelen I finally came around integrating the soft-delete changes in Terraform. What I notice from debug logs is that the server never sets the Here is a link to a testsuite run with DEBUG logs enabled: Note: download the logs from the menu in the 3 dots in the upper right of the black logs screen for faster search. 😉 If you search for In https://github.com/terraform-providers/terraform-provider-gitlab/pull/291, I asked for help from 2 Gitlab employees. I hope we finally get some support on this one. My free time is not endless... |
Same here... Let's see what they come back with. |
@svanharmelen my findings so far can be read here: https://github.com/terraform-providers/terraform-provider-gitlab/pull/291#issuecomment-607665336 In short for you, here is a change request:
Note the difference in the last two characters of the field name. |
Done @ringods! I'll create another release today or tomorrow, but want to include another (bigger) change to make things more flexible moving forwards. |
Tnx. Gitlab opened an issue also about the inconsistency of the field names: |
Filing this ticket not as a bug report, more as an awareness.
The test suites for the Gitlab Terraform & Pulumi providers became instable since Gitlab 12.6. After some investigation, it seems that soft-delete of Projects was introduced in that version by changing the behaviour of
DELETE /projects/{id}
.More context here:
https://github.com/terraform-providers/terraform-provider-gitlab/issues/263
which links to even more gitlab tickets.
So be aware that a delete is not necessarily a hard delete.
The text was updated successfully, but these errors were encountered: