CA-153279: don't complain if there's no tapdisk to signal #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rotating tapdisk logs we blindly tell all tapdisks (even if no tapdisk exists) to refresh their logs. If no tapdisk exists, an error message will be logged in /root/dead.letter, which might lead to dom0 root file-system free space implications. Signed-off-by: Thanos Makatos <thanos.makatos@citrix.com>
martinjorge
pushed a commit
to martinjorge/blktap
that referenced
this pull request
Sep 23, 2015
When rotating tapdisk logs we blindly tell all tapdisks (even if no tapdisk exists) to refresh their logs. If no tapdisk exists, an error message will be logged in /root/dead.letter, which might lead to dom0 root file-system free space implications. Signed-off-by: Thanos Makatos <thanos.makatos@citrix.com> Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xapi-project#145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rotating tapdisk logs we blindly tell all tapdisks (even if no
tapdisk exists) to refresh their logs. If no tapdisk exists, an error
message will be logged in /root/dead.letter, which might lead to dom0
root file-system free space implications.
Signed-off-by: Thanos Makatos thanos.makatos@citrix.com