Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Lwt_log to the logs library #39

Open
gaborigloi opened this issue Mar 2, 2018 · 3 comments
Open

Move from Lwt_log to the logs library #39

gaborigloi opened this issue Mar 2, 2018 · 3 comments

Comments

@gaborigloi
Copy link
Contributor

gaborigloi commented Mar 2, 2018

We currently use the Lwt_log library for logging in this repo. As ocsigen/lwt#468 (comment) said, Lwt_log might be deprecated in the future.
Therefore, we should move this repo to use the logs libray instead, which is the replacement recommended in the above thread. Its Logs_lwt library provides logging functions for Lwt.

Resources:

@mseri
Copy link
Collaborator

mseri commented Mar 2, 2018

Are also xcp-networkd and wsproxy affected?

@gaborigloi
Copy link
Contributor Author

wsprox is: xapi-project/wsproxy#13 , but xcp-networkd isn't

@edwintorok
Copy link
Contributor

FWIW here is an example of using the Logs module: https://github.com/xapi-project/testarossa/blob/master/lib/context.ml. In this case I used the blocking version of logs, because it was all CLI code and I actually wanted the blocking behaviour.
For the daemons we want to use the Lwt reporter probably: http://erratique.ch/software/logs/doc/Logs_lwt.html#report_ex

edwintorok pushed a commit to edwintorok/message-switch that referenced this issue Sep 20, 2021
also pass -j to dune when running tests

Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants