-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from Lwt_log to the logs library #39
Comments
Are also xcp-networkd and wsproxy affected? |
wsprox is: xapi-project/wsproxy#13 , but xcp-networkd isn't |
FWIW here is an example of using the Logs module: https://github.com/xapi-project/testarossa/blob/master/lib/context.ml. In this case I used the blocking version of logs, because it was all CLI code and I actually wanted the blocking behaviour. |
also pass -j to dune when running tests Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
We currently use the
Lwt_log
library for logging in this repo. As ocsigen/lwt#468 (comment) said,Lwt_log
might be deprecated in the future.Therefore, we should move this repo to use the
logs
libray instead, which is the replacement recommended in the above thread. ItsLogs_lwt
library provides logging functions forLwt
.Resources:
Lwt_log
module in Lwtlogs
libraryThe text was updated successfully, but these errors were encountered: