CP-12200: Files beloging to SM moved from dom0 #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First line of commit message is a like a title: no periods, no multiple sentences, surely no longer than 72 chars (if 50 usually better). Following block starts indented: it is not the continuation of the first line, it is just a more detailed description. |
|
|
||
| %config /etc/modprobe.d/cifs.conf |
There was a problem hiding this comment.
Is there a reason why it is detached from the rest?
martinjorge
force-pushed
the
CP-12200
branch
2 times, most recently
from
18d742d
to
8769d1b
Compare
martinjorge
changed the title
Moved files and modified Makefile from dom0 that belong to sm. -dom0.hg/Makefile: lvm.conf and rules instructions -> sm/mk/spec.in and sm/Makefile -dom0.hg/.../58-xapi.rules -> sm/etc/udev + rules files from sm/multipath -dom0.hg/.../cifs.conf -> sm/etc/modprobe.d/cifs.conf Signed-off-by: Jorge Martin <jorge.martin@citrix.com>
|
Reviewed-by: Germano Percossi germano.percossi@citrix.com |
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
Moved files and modified Makefile from dom0 that belong to sm. -dom0.hg/Makefile: lvm.conf and rules instructions -> sm/mk/spec.in and sm/Makefile -dom0.hg/.../58-xapi.rules -> sm/etc/udev + rules files from sm/multipath -dom0.hg/.../cifs.conf -> sm/etc/modprobe.d/cifs.conf Reviewed-by: Germano Percossi <germano.percossi@citrix.com> GitHub: closes xapi-project#262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed files from dom0 to sm. The changes are as follows:
Signed-off-by: Jorge Martin jorge.martin@citrix.com