If no NFS ACLs provided, assume everyone #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamreis
commented
Feb 12, 2021
benjamreis
force-pushed
the
do-not-crash-if-no-nfs-acl
branch
from
9c27cdf
to
60a7d87
Compare
|
Can |
Of course, if you know what the response looks like, just make the return value from the mock look like that. |
|
Okay thanks, I'll add a test then :) |
benjamreis
force-pushed
the
do-not-crash-if-no-nfs-acl
branch
2 times, most recently
from
2738f6f
to
93379ab
Compare
|
Test added and successfull, this is good to review, and that's one more nfs method covered by the test! 👍 |
benjamreis
changed the title
Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
benjamreis
force-pushed
the
do-not-crash-if-no-nfs-acl
branch
from
93379ab
to
b4aec6d
Compare
|
Hi! Any changes required? Or something is missing? Tests and test coverage should be fine. Regards! |
TimSmithCtx
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BenjiReis benjamin.reis@vates.fr
Solves: #511
As detailed in the issue, some devices (mostly QNAS devices) do not provide with NFS ACLs in
showmount -ereturn, in this case we need to assume everyone is accepted, thereforeaccess = "*".