CA-83270: Remove the default value to verify_cert. #123

Merged
merged 1 commit into from Mar 21, 2013

Conversation

Projects
None yet
2 participants
Contributor

jeromemaloberti commented Feb 1, 2013

It prevents Stunnel.connect of actually checking the certificate.
The line: assert (not (verify_cert && use_tunnel_cache));
must be removed since verify_cert=None is undefined.
However, stunnel_cache need to be able to differentiate verified and
unverified connections after this commit, therefore the changes for
XOP-229 are necessary.

Signed-off-by: Jerome Maloberti jerome.maloberti@citrix.com

CA-83270: Remove the default value to verify_cert.
It prevents Stunnel.connect of actually checking the certificate.
The line: assert (not (verify_cert && use_tunnel_cache));
must be removed since verify_cert=None is undefined.
However, stunnel_cache need to be able to differentiate verified and
unverified connections after this commit, therefore the changes for
XOP-229 are necessary.

Signed-off-by: Jerome Maloberti <jerome.maloberti@citrix.com>

thomassa pushed a commit that referenced this pull request Mar 21, 2013

Merge pull request #123 from jeromemaloberti/CA-83270
CA-83270: Remove the default value to verify_cert.

@thomassa thomassa merged commit d6b603b into xapi-project:master Mar 21, 2013

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment