Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CA-94335: Dom0 should be managed in xenopsd before the record is created. #1006

Merged
merged 1 commit into from Mar 7, 2013

Conversation

Projects
None yet
3 participants
Contributor

jeromemaloberti commented Feb 6, 2013

Should be tested very carefully, since it changes the order of initialization.

Signed-off-by: Jerome Maloberti jerome.maloberti@citrix.com

@jeromemaloberti jeromemaloberti CA-94335: Dom0 should be managed in xenopsd before the record is crea…
…ted.

Signed-off-by: Jerome Maloberti <jerome.maloberti@citrix.com>
78e9f88
Collaborator

djs55 commented Feb 6, 2013

Slightly tangentially: do you know why we add dom0 to xenopsd at all? It's causing me problems in my branch and it prevents us from running more than 1 xenopsd. It shouldn't be needed for starting normal guests. It isn't because of assumptions made in the SMRT is it?

Contributor

jeromemaloberti commented Feb 6, 2013

Actually, I don't know why dom0 is added to xenopsd, and I don't know what is SMRT either :). Sorry.
I just moved manage_dom0 early in the sequence because it was conflicting with the creation of the dom0 record which tries to get the VM.stat of dom0 without success, causing memory-target to be overwritten and an ugly error message in xensource.log. Since dom0 is no more ballooned it may be worth reconsider its initialization.
The information needed to create the record could be queried from Xen in Xapi too, and I'm not sure that writing the memory keys in xenstore is particularly useful for dom0.

Owner

jonludlam commented Feb 21, 2013

Let's do a before-and-after BST for this one. I'll merge in the other changesets that are ready then schedule the 'before' one.

@jonludlam jonludlam added a commit that referenced this pull request Mar 7, 2013

@jonludlam jonludlam Merge pull request #1006 from jeromemaloberti/CA-94335-bis
CA-94335: Dom0 should be managed in xenopsd before the record is created.
a64413b

@jonludlam jonludlam merged commit a64413b into xapi-project:master Mar 7, 2013

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment