PR-1510 LACP XenAPI improvements #1007

merged 6 commits into from Feb 28, 2013


None yet
3 participants

mcclurmc commented Feb 7, 2013

This is for the Tallahassee release.

Mike McClurg added some commits Nov 30, 2012

Mike McClurg PR-1510: LACP timeout, aggregator/actor parameters settable
LACP timeout, aggregator/actor parameters are now settable through XenAPI and
CLI. New bond parameters are lacp-time, lacp-aggregator-key and lacp-actor-key.

Signed-off-by: Mike McClurg <>
Mike McClurg Refactor Network_utils.Ovs to functorize vsctl commands for testing
Signed-off-by: Mike McClurg <>
Mike McClurg PR-1510: add unit tests for LACP params setting
Signed-off-by: Mike McClurg <>
Mike McClurg PR-1510: bond parameters either have defaults or are omitted
Signed-off-by: Mike McClurg <>
Mike McClurg PR-1510: More test cases
Signed-off-by: Mike McClurg <>

Well, I should probably remove these lines, shouldn't I? I'll add a commit to fix this early next week.

Mike McClurg Remove unecessary debug line
Signed-off-by: Mike McClurg <>

jonludlam commented Feb 28, 2013

I take it this has already gone into tallahassee - was it reviewed then?


mcclurmc commented Feb 28, 2013

Yes, this is in Tallahassee already. Sorry for breaking protocol :( @robhoes had reviewed this code with me while I developed it, and I haven't heard any negative feedback from the Netscaler guys, so I'm confident that this can go into trunk.


jonludlam commented Feb 28, 2013

Thanks @mcclurmc - will merge then.

@jonludlam jonludlam added a commit that referenced this pull request Feb 28, 2013

@jonludlam jonludlam Merge pull request #1007 from mcclurmc/pr1510-lacp-api-improvements-r…

PR-1510 LACP XenAPI improvements

@jonludlam jonludlam merged commit 0bf4b9b into xapi-project:master Feb 28, 2013

1 check passed

default Merged build finished.

robhoes commented Mar 20, 2013

@mcclurmc Should this go into clearwater as well? Assuming tallahassee will get a smaller version number than clearwater, I think it may be weird to have a feature in tallahassee but not in clearwater. What do you think? Master also has this in, and master will have a larger version number than clearwater, which makes it even weirder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment