CA-86883: Detach SR if SR.destroy fails #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage backend can destroy an SR only if it is attached. Therefore when xapi wants to destroy an SR, first it attaches it. When the backend destroys the SR it is no longer attached. This change adds exception handling so that if the backend fails to destroy the SR, xapi will detach it.
|
This is a mechanically created copy of my pull-request that made the same change in the Master (trunk-ring3) branch: #1030 |
malcolmcrossley
pushed a commit
that referenced
this pull request
Apr 29, 2013
CA-86883: Detach SR if SR.destroy fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLEARWATER
The storage backend can destroy an SR only if it is attached.
Therefore when xapi wants to destroy an SR, first it attaches it.
When the backend destroys the SR it is no longer attached.
This change adds exception handling so that if the backend fails
to destroy the SR, xapi will detach it.