SANIBEL: SCTX-1283: Fix race condition when a vm-shutdown is initiated during xapi-startup #1085

Merged
merged 1 commit into from Jun 14, 2013

6 participants

@akshayramani

If a shutdown in initiated when xapi is starting up , dbsyc_slave.ml will mark the domain as running AFTER the clean shutdown. Hence the VM is marked as running and resident_on is marked as null.

This commit ensures it checks that the domain is not in a shutdown state before marking it as running.

@xen-git
Xapi Project member

Can one of the admins verify this patch?

@jonludlam
Xapi Project member

Assigning to @jeromemaloberti for review

@akshayramani

Have changed the commit as per discussions with @jeromemaloberti

@xen-git
Xapi Project member

Can one of the admins verify this patch?

@jeromemaloberti

Indentation is still not correct.

@akshayramani akshayramani SCTX-1283: Fix race condition when a vm-shutdown is inititated during…
… a xapi start-up.

Signed-off-by: Akshay Ramani <akshay.ramani@citrix.com>
a7670de
@xen-git
Xapi Project member

Can one of the admins verify this patch?

@jonludlam
Xapi Project member

ok to test

@xen-git
Xapi Project member

Can one of the admins verify this patch?

@thomassa
Xapi Project member

ok to test
(@xen-git)

@xen-git
Xapi Project member

Can one of the admins verify this patch?

@thomassa
Xapi Project member

ok to test
(This has been languishing for a while so it makes sense to check that it still applies cleanly.)

@thomassa
Xapi Project member

ok to test

@thomassa
Xapi Project member

Jerome says the fix looked right apart from the indentation, so I'm merging this now.

@thomassa thomassa merged commit 9abe90c into xapi-project:sanibel-lcm Jun 14, 2013

1 check passed

Details default Merged build finished.
@zli
Xapi Project member

This should have been HFX-817 of Obelix, but it got into the branch before Obelix was created. I'm adding this comment just for reference, hopefully when we search "Obelix" using github, it will show up (together with the other 10 pull requests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment