Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CA-97232: Optimize host-evacuate #1113

Merged
merged 3 commits into from Apr 12, 2013

Conversation

Projects
None yet
3 participants
Contributor

siddharthv commented Mar 25, 2013

When host-evacuate is in progress:
Case-1: Ignore VMs that are being shutdown
Case-2: Prevent VMs from starting on the host that is being evacuated

Signed-off-by: Siddharth Vinothkumar siddharth.vinothkumar@citrix.com

@johnelse johnelse was assigned Mar 27, 2013

@johnelse johnelse commented on the diff Mar 27, 2013

ocaml/idl/api_errors.ml
@@ -368,6 +368,7 @@ let ha_constraint_violation_network_not_shared = "HA_CONSTRAINT_VIOLATION_NETWOR
let ha_operation_would_break_failover_plan = "HA_OPERATION_WOULD_BREAK_FAILOVER_PLAN"
let cannot_evacuate_host = "CANNOT_EVACUATE_HOST"
+let host_evacuate_in_progress = "HOST_EVACUATE_IN_PROGRESS"
@johnelse

johnelse Mar 27, 2013

Collaborator

Could you add a description for this error to ocaml/idl/datamodel.ml? Thanks.

What's the status of this pull request? I have a matching one for clearwater, this is a critical level bug and we're heading towards a code freeze for an upcoming clearwater code drop.

Collaborator

johnelse commented Apr 7, 2013

Hi Malcolm, I haven't reviewed this yet as we're not merging anything to trunk-ring3 until Xen 4.2 is merged. If you think this is important enough to go into Clearwater before it gets into trunk, I can review this on Monday.

Collaborator

johnelse commented Apr 8, 2013

@siddharthv Although this blocks VM.start_on from starting a VM on an evacuating host, it doesn't look like this code affects VM.start, which uses forward_to_suitable_host to choose a host to start a VM on.

I'd recommend adding a check to Xapi_vm_helpers.vm_can_run_on_host that the host isn't evacuating - this will make sure that VM.start only starts VMs on hosts which are not evacuating.

siddharthv added some commits Mar 25, 2013

@siddharthv siddharthv CA-97232: Optimize host-evacuate
When host-evacuate is in progress:
Case-1: Ignore VMs that are being shutdown
Case-2: Prevent VMs from starting on that host

Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
3cca564
@siddharthv siddharthv Adding error message to datamodel
Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
2e48b08
@siddharthv siddharthv Adding additional check in Xapi_vm_helpers.vm_can_run_on_host for VM.…
…Start

Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
0ef0c3d
Collaborator

johnelse commented Apr 12, 2013

This looks good now

@johnelse johnelse added a commit that referenced this pull request Apr 12, 2013

@johnelse johnelse Merge pull request #1113 from siddharthv/CA-97232-C12
CA-97232: Optimize host-evacuate
858cf60

@johnelse johnelse merged commit 858cf60 into xapi-project:master Apr 12, 2013

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment