Cp4393: Xapi work for bistromath #1117

Merged
merged 1 commit into from Apr 8, 2013

Projects

None yet

4 participants

@vbmithr

No description provided.

@xen-git
Xapi Project member

Can one of the admins verify this patch?

@jonludlam jonludlam commented on an outdated diff Mar 26, 2013
ocaml/xapi/xapi_xenops.ml
@@ -400,7 +400,11 @@ module MD = struct
(fun (k, v) -> k <> "tsc_mode" || List.mem v ["0"; "1"; "2"; "3"])
platformdata
in
-
+ (* PR-1061: Pick other-config:{vgpu_pci_id,vgpu_config} *)
+ let platformdata = (List.fold_left (fun acc (k,v) -> if try String.sub k
+ 0 4 = "vgpu" with Invalid_argument _ -> false then (k,v) :: acc else acc)
+ [] vm.API.vM_other_config) @ platformdata
@jonludlam
jonludlam Mar 26, 2013

Why are these flags in other_config and not platform_data?

@robhoes robhoes was assigned Mar 26, 2013
@robhoes
Xapi Project member

Two small things:

  • Please add a signed-off-by line to each commit.
  • The indentation looks a bit irregular.
@vbmithr

Please review again.

@xen-git
Xapi Project member

Can one of the admins verify this patch?

@robhoes
Xapi Project member

Also, the first two commits still need signed-off-by lines...

Vincent Bernardoff PR-1061: start demu if the VM has the right keys in platformdata
Signed-off-by: Vincent Bernardoff <vincent.bernardoff@citrix.com>
488ce7b
@robhoes
Xapi Project member

ok to test

@robhoes
Xapi Project member

This looks good now.

@robhoes
Xapi Project member

The build failed...

@jonludlam
Xapi Project member

It failed because xen-git doesn't know about any bistromath branch

@jonludlam
Xapi Project member

test this please

@jonludlam jonludlam merged commit 24bbd5a into xapi-project:bistromath Apr 8, 2013

1 check passed

Details default Merged build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment