New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API to set GRO (and potentially other "properties") on PIFs #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported from xcp-idl.git 00439e8 Signed-off-by: Rob Hoes <rob.hoes@citrix.com> Imported-by: John Else <john.else@citrix.com>
Signed-off-by: John Else <john.else@citrix.com>
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
We'll add some constraints to this in the next patches. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Signed-off-by: John Else <john.else@citrix.com>
Signed-off-by: John Else <john.else@citrix.com>
The only property that we currently recognise is "gro", which by default has the value "on". GRO is a low-level property of a network interface, which applies to physical PIFs, and to a bond as a collection of physical PIFs. We therefore currently distinguish the following cases: * A physical PIF gets the default properties when introduced. * A bond PIF inherits the PIF properties from the primary slave. * A VLAN or Tunnel PIF does not have properties. It is assumed to implicitly inherit the properties from the PIF it is based on. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
We currently only accept the "gro" property, which can be "on" of "off". Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
… PIFs Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
And those properties will become the bond's properties. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Signed-off-by: Rob Hoes <rob.hoes@citrix.com> Conflicts: ocaml/idl/datamodel.ml ocaml/xapi/xapi_db_upgrade.ml
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
For the Linux bridge case, it is important that we set the ethtool params on bond and VLAN devices for things to work well. VLANs inherit the properties from the PIF they are based off. For bonds, the properties of all slaves are the same as the master's. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Looks good, but please also add #1593. |
@robhoes Aha, good catch :) |
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
johnelse
added a commit
that referenced
this pull request
Apr 16, 2014
API to set GRO (and potentially other "properties") on PIFs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from