Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dom0 mem_usage alert #1836

Merged
merged 5 commits into from Jul 22, 2014

Conversation

@zli
Copy link
Member

commented Jul 22, 2014

No description provided.

Update the default priority setting in the comment section
... to reflect the changes of PR-1455.

Signed-off-by: Zheng Li <dev@zheng.li>
# We consider the sum of res memory and swap in use as the hard demand
# of mem usage, it is bad if this number is beyond the physical mem, as
# in such case swapping is obligatory rather than voluntary, hence
# degragating the performance. We define the percentage metrics as

This comment has been minimized.

Copy link
@thomassa

thomassa Jul 22, 2014

Spelling: "degrading" (not "degragating")

This comment has been minimized.

Copy link
@zli

zli Jul 22, 2014

Author Member

Updated.

def generate_body(self):
return \
'The memory demand on "%s" is about %.1f%% of the physical memory of the domain. ' \
'Occasional performance degradation can be expected when memory swapping is enforced to happen.\n' \

This comment has been minimized.

Copy link
@thomassa

thomassa Jul 22, 2014

Should be "forced" not "enforced".
Does this understate the severity of the problem? I suspect "occasional performance degradation" could easily snowball into something much worse (and we have only 512MiBytes of swap-space).

This comment has been minimized.

Copy link
@zli

zli Jul 22, 2014

Author Member

Typo fixed.

I don't think there is a best config for this, though I believe it makes some sense for the current setting of our system (with a comparatively small swap). I've also update the threshold to 95% which means it will get triggered when the hard mem demand is approaching the physical memory of the system, just in case that swap might become totally neglectable in future system.

@thomassa

This comment has been minimized.

Copy link

commented Jul 22, 2014

Looks fine except for tiny cosmetic things.
Probably worth fixing the text that goes into the alarm email.

zli added 4 commits Jul 21, 2014
CP-9091: Add Dom0 mem_usage alert for perfmon
Signed-off-by: Zheng Li <dev@zheng.li>
CP-9093: decrease the inhibit period of fs_usage alert
It seems that the inhibit period of fs_usage alert is set too long (one week).
The consequence is that the alerts will be sent out much less frequently
(not showing much emergency as we want). Also it will mute the alarm for a week
long even if a different occurence shows up later on (after the first occurence
being addressed already) during this period of time.

Signed-off-by: Zheng Li <dev@zheng.li>
CP-9091: Add mem_usage logic in mail-alarm
Signed-off-by: Zheng Li <dev@zheng.li>
CP-9093: fix a debug message error
Signed-off-by: Zheng Li <dev@zheng.li>
thomassa pushed a commit that referenced this pull request Jul 22, 2014

@thomassa thomassa merged commit 6cba889 into xapi-project:master Jul 22, 2014

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.