CA-220505: Destroy stale VM record on destination pool on failed … #2783
Conversation
| @@ -966,6 +966,22 @@ let migrate_send' ~__context ~vm ~dest ~live ~vdi_map ~vif_map ~options = | |||
| debug "Mirror failed for VDI: %s" failed_vdi; | |||
| raise (Api_errors.Server_error(Api_errors.mirror_failed,[Ref.string_of vconf.vdi])) | |||
| end; | |||
|
|
|||
| if (TaskHelper.is_cancelling ~__context) && not is_intra_pool then | |||
There was a problem hiding this comment.
You are using parentheses for the TaskHelper.is_canceling function application but not for not. You don't need parentheses in either case (it's fine to write if f x && not y then .. else ..) but I think this should be consistent.
| if (TaskHelper.is_cancelling ~__context) && not is_intra_pool then | ||
| begin match e with | ||
| | Storage_interface.Does_not_exist(_) -> | ||
| if (Db.is_valid_ref __context vm) then begin |
There was a problem hiding this comment.
You are using parentheses again here. They are not strictly needed and the convention is not to use them for simple if-expressions.
There was a problem hiding this comment.
@lindig Thanks for the review, I have removed the parentheses.
|
We're matching some very specific conditions here - it seems odd that we only destroy the remote VM if we catch 'Storage_interface.Does_not_exist' - can you justify that? |
|
@jonludlam I have seen this specific error |
Cancelling cross-pool SXM ends up in destroying VDIs and stale VM record on destination Pool. On SXM failure, If VM exists on source Pool then destroy the stale VM record on destination Pool. Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
|
@jonludlam Thanks for the suggestion, I have updated the PR accordingly. Please have a look :) |
sharady
changed the title
|
Paging @jonludlam ;) |
|
Looks good now, thanks! |
…SXM.
Cancelling cross-pool SXM ends up in destroying VDIs and stale VM record
on destination Pool.
After cancellation, If VM exists on source Pool then destroy the stale VM
record on destination Pool.
Signed-off-by: Sharad Yadav sharad.yadav@citrix.com