CA-74343: Fix HA on VLANs (tampa-lcm) #871

Merged
merged 2 commits into from Oct 18, 2012

Conversation

Projects
None yet
3 participants
@robhoes
Member

robhoes commented Sep 28, 2012

The recent change to not automatically plug VLANs on host boot (for
scalability reasons), led the HA code to believe that VMs on VLANs
were not agile, even if they were.

It turns out that the agility check for networking is too strict.
Currently, xapi only considers a VM agile if all its networks

  1. have PIFs on all enabled hosts, AND
  2. have all those PIFs attached/plugged.

This is too strict, because a PIF can always be plugged, unless it is
a bond slave, and xapi automatically plugs a PIF when it is needed by a
VM.

Therefore, the agility check was changed to require that a VM's networks

  1. have PIFs on all enabled hosts, AND
  2. none of those PIFs are bond slaves.

Signed-off-by: Rob Hoes rob.hoes@citrix.com

robhoes added some commits Sep 26, 2012

CA-74343: Fix HA on VLANs
The recent change to not automatically plug VLANs on host boot (for
scalability reasons), led the HA code to believe that VMs on VLANs
were not agile, even if they were.

It turns out that the agility check for networking is too strict.
Currently, xapi only considers a VM agile if all its networks
1. have PIFs on all enabled hosts, AND
2. have all those PIFs attached/plugged.

This is too strict, because a PIF can always be plugged, unless it is
a bond slave, and xapi automatically plugs a PIF when it is needed by a
VM.

Therefore, the agility check was changed to require that a VM's networks
1. have PIFs on all enabled hosts, AND
2. none of those PIFs are bond slaves.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Use is_valid_ref rather than comparing with Ref.null
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
@xen-git

This comment has been minimized.

Show comment
Hide comment
@xen-git

xen-git Oct 5, 2012

Member

robhoes/xen-api@c93c5950cbfab0: Build succeeded. Can merge pull request.

Member

xen-git commented Oct 5, 2012

robhoes/xen-api@c93c5950cbfab0: Build succeeded. Can merge pull request.

@xen-git

This comment has been minimized.

Show comment
Hide comment
@xen-git

xen-git Oct 12, 2012

Member

robhoes/xen-api@c93c595c3375f4: Build succeeded. Can merge pull request.

Member

xen-git commented Oct 12, 2012

robhoes/xen-api@c93c595c3375f4: Build succeeded. Can merge pull request.

@xen-git

This comment has been minimized.

Show comment
Hide comment
@xen-git

xen-git Oct 13, 2012

Member

robhoes/xen-api@c93c5958c7cee0: Build succeeded. Can merge pull request.

Member

xen-git commented Oct 13, 2012

robhoes/xen-api@c93c5958c7cee0: Build succeeded. Can merge pull request.

@xen-git

This comment has been minimized.

Show comment
Hide comment
@xen-git

xen-git Oct 14, 2012

Member

robhoes/xen-api@c93c5956c55137: Build succeeded. Can merge pull request.

Member

xen-git commented Oct 14, 2012

robhoes/xen-api@c93c5956c55137: Build succeeded. Can merge pull request.

@jonludlam

This comment has been minimized.

Show comment
Hide comment
@jonludlam

jonludlam Oct 18, 2012

Member

@xen-git Approved-lcm

Member

jonludlam commented Oct 18, 2012

@xen-git Approved-lcm

@xen-git

This comment has been minimized.

Show comment
Hide comment
@xen-git

xen-git Oct 18, 2012

Member

robhoes/xen-api@c93c595a0e1f3a: Build succeeded. Pull request merged.

Member

xen-git commented Oct 18, 2012

robhoes/xen-api@c93c595a0e1f3a: Build succeeded. Pull request merged.

xen-git pushed a commit that referenced this pull request Oct 18, 2012

@xen-git xen-git merged commit c93c595 into xapi-project:tampa-lcm Oct 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment