CA-90457: Don't set rebalance-interval for LACP bonds (tampa-lcm) #872

Merged
merged 2 commits into from Oct 18, 2012

Conversation

Projects
None yet
4 participants
Owner

robhoes commented Sep 28, 2012

No description provided.

johnelse and others added some commits Sep 14, 2012

CA-90457: Don't set rebalance-interval for LACP bonds.
Signed-off-by: John Else <john.else@citrix.com>
Revert the rebalance-interval changes to networkd of e9219fa
The policies for which values are set in the network layer should be in xapi. Networkd should
just do do what xapi says.

After this change, the default rebalance-intervals are unchanged: for balance-slb bonds is 30min,
while for LACP bonds, the value is unset and the default from the ovs is used (10s). However, the
change makes it possible for the user to override the rebalance-interval using the other-config key,
even in the LACP case (for whatever reason).

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Owner

xen-git commented Oct 5, 2012

robhoes/xen-api@07fe89d0cbfab0: Build succeeded. Can merge pull request.

Owner

xen-git commented Oct 12, 2012

robhoes/xen-api@07fe89dc3375f4: Build succeeded. Can merge pull request.

Owner

xen-git commented Oct 13, 2012

robhoes/xen-api@07fe89d8c7cee0: Build succeeded. Can merge pull request.

Owner

xen-git commented Oct 14, 2012

robhoes/xen-api@07fe89d6c55137: Build succeeded. Can merge pull request.

Owner

jonludlam commented Oct 18, 2012

@xen-git Approved-lcm

xen-git pushed a commit that referenced this pull request Oct 18, 2012

@xen-git xen-git merged commit 07fe89d into xapi-project:tampa-lcm Oct 18, 2012

Owner

xen-git commented Oct 18, 2012

robhoes/xen-api@07fe89d9f8a816: Build succeeded. Pull request merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment