CA-90857: VIF Port Locking Persistence #912

Merged
merged 1 commit into from Nov 23, 2012

Conversation

Projects
None yet
4 participants
Contributor

siddharthv commented Nov 7, 2012

Issue:
While importing a VM through XenCenter, the VIF imported is destroyed and recreated.
The locking-mode field for VIF was of type DynamicRO and the VIF recreated by XenCenter always used to set it to network default.

Solution:
The locking-mode field for VIF was changed to type StaticRO, the constructor signature modified and then the vif record was constructed locally to preserve this field

Signed-off-by: Siddharth Vinothkumar siddharth.vinothkumar@citrix.com

Contributor

jeromemaloberti commented Nov 7, 2012

@xen-git check.

Owner

xen-git commented Nov 7, 2012

siddharthv/xen-api@50b8edddbd1565: Build succeeded. Can merge pull request.

Owner

robhoes commented Nov 7, 2012

@siddharthv Could you please just add a description to the commit message that explains why you are making this change? Thanks.

Owner

xen-git commented Nov 9, 2012

siddharthv/xen-api@50b8edd2c0fbe1: Build succeeded. Can merge pull request.

Owner

xen-git commented Nov 9, 2012

siddharthv/xen-api@50b8edd8cddb3a: Build succeeded. Can merge pull request.

Owner

xen-git commented Nov 10, 2012

siddharthv/xen-api@50b8eddf0f8d51: Build succeeded. Can merge pull request.

Owner

xen-git commented Nov 20, 2012

siddharthv/xen-api@50b8edd0817d46: Build succeeded. Can merge pull request.

Owner

xen-git commented Nov 22, 2012

siddharthv/xen-api@50b8edd4baae9e: Build succeeded. Can merge pull request.

@siddharthv siddharthv CA-90857: VIF Port Locking Persistence
Issue:
While importing a VM through XenCenter, the VIF imported is destroyed and recreated.
The locking-mode field for VIF was of type DynamicRO and the VIF recreated by XenCenter always used to set it to network default.

Solution:
The locking-mode field for VIF was changed to type StaticRO, the constructor signature modified and then the vif record was constructed locally to preserve this field.

Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
40daa33
Owner

xen-git commented Nov 23, 2012

siddharthv/xen-api@40daa334baae9e: Build succeeded. Can merge pull request.

Owner

robhoes commented Nov 23, 2012

@xen-git approved

Owner

xen-git commented Nov 23, 2012

siddharthv/xen-api@40daa334baae9e: Build succeeded. Pull request merged.

@xen-git xen-git pushed a commit that referenced this pull request Nov 23, 2012

xen-git Merge pull request #912 from siddharthv/CA-90857 094c895

xen-git closed this Nov 23, 2012

@xen-git xen-git merged commit 40daa33 into xapi-project:master Nov 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment